From 8b4ae33bfaef4d310138d0a1cc3b71b26746c395 Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Date: Thu, 25 Apr 2019 16:05:15 -0700 Subject: [PATCH] Cleanup 20190425 (#34995) * Update project urls * remove jquery-notifier, update react-test-renderer 1. jquery-notifier was types for a type-only package. 2. react-test-renderer's test incorrectly assumed that was an html tag. This is now an error. I updated the test to use
, since that's a tag I've heard of before. * Fix space lint * Use typescript for removing non-npm package * Reorder names in notNeededpackages.json * Point to real version of typescript --- notNeededPackages.json | 6 ++++ types/istanbul-lib-coverage/index.d.ts | 2 +- types/istanbul-lib-hook/index.d.ts | 2 +- types/istanbul-lib-instrument/index.d.ts | 2 +- types/istanbul-lib-report/index.d.ts | 2 +- types/istanbul-lib-source-maps/index.d.ts | 2 +- types/jquery-notifier/index.d.ts | 18 ----------- .../jquery-notifier/jquery-notifier-tests.ts | 31 ------------------- types/jquery-notifier/tsconfig.json | 24 -------------- types/jquery-notifier/tslint.json | 1 - types/natsort/index.d.ts | 2 +- types/react-instantsearch-core/index.d.ts | 2 +- types/react-instantsearch-dom/index.d.ts | 2 +- types/react-instantsearch-native/index.d.ts | 2 +- .../react-test-renderer-tests.ts | 2 +- 15 files changed, 16 insertions(+), 84 deletions(-) delete mode 100644 types/jquery-notifier/index.d.ts delete mode 100644 types/jquery-notifier/jquery-notifier-tests.ts delete mode 100644 types/jquery-notifier/tsconfig.json delete mode 100644 types/jquery-notifier/tslint.json diff --git a/notNeededPackages.json b/notNeededPackages.json index 6285d140cf..61d5f83532 100644 --- a/notNeededPackages.json +++ b/notNeededPackages.json @@ -1416,6 +1416,12 @@ "sourceRepoURL": "https://github.com/jpush/jpush-react-native", "asOfVersion": "2.0.0" }, + { + "libraryName": "typescript", + "typingsPackageName": "jquery-notifier", + "sourceRepoURL": "https://github.com/Microsoft/TypeScript", + "asOfVersion": "1.3.0" + }, { "libraryName": "jquery.ajaxfile", "typingsPackageName": "jquery.ajaxfile", diff --git a/types/istanbul-lib-coverage/index.d.ts b/types/istanbul-lib-coverage/index.d.ts index c8a96d606f..fc8a8dedeb 100644 --- a/types/istanbul-lib-coverage/index.d.ts +++ b/types/istanbul-lib-coverage/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for istanbul-lib-coverage 2.0 -// Project: https://github.com/istanbuljs/istanbuljs +// Project: https://istanbul.js.org, https://github.com/istanbuljs/istanbuljs // Definitions by: Jason Cheatham // Lorenzo Rapetti // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped diff --git a/types/istanbul-lib-hook/index.d.ts b/types/istanbul-lib-hook/index.d.ts index e4cbe0cd97..cf16d15e6a 100644 --- a/types/istanbul-lib-hook/index.d.ts +++ b/types/istanbul-lib-hook/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for istanbul-lib-hook 1.0 -// Project: https://github.com/istanbuljs/istanbuljs +// Project: https://istanbul.js.org, https://github.com/istanbuljs/istanbuljs // Definitions by: Jason Cheatham // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.4 diff --git a/types/istanbul-lib-instrument/index.d.ts b/types/istanbul-lib-instrument/index.d.ts index 1b749a893c..b4264489e6 100644 --- a/types/istanbul-lib-instrument/index.d.ts +++ b/types/istanbul-lib-instrument/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for istanbul-lib-instrument 1.7 -// Project: https://github.com/istanbuljs/istanbuljs +// Project: https://istanbul.js.org, https://github.com/istanbuljs/istanbuljs // Definitions by: Jason Cheatham // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 diff --git a/types/istanbul-lib-report/index.d.ts b/types/istanbul-lib-report/index.d.ts index 709bc8030b..9dcb5bff44 100644 --- a/types/istanbul-lib-report/index.d.ts +++ b/types/istanbul-lib-report/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for istanbul-lib-report 1.1 -// Project: https://github.com/istanbuljs/istanbuljs +// Project: https://istanbul.js.org, https://github.com/istanbuljs/istanbuljs // Definitions by: Jason Cheatham // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.4 diff --git a/types/istanbul-lib-source-maps/index.d.ts b/types/istanbul-lib-source-maps/index.d.ts index 71ae7f0dec..12569d62cd 100644 --- a/types/istanbul-lib-source-maps/index.d.ts +++ b/types/istanbul-lib-source-maps/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for istanbul-lib-source-maps 1.2 -// Project: https://github.com/istanbuljs/istanbuljs +// Project: https://istanbul.js.org, https://github.com/istanbuljs/istanbuljs // Definitions by: Jason Cheatham // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.4 diff --git a/types/jquery-notifier/index.d.ts b/types/jquery-notifier/index.d.ts deleted file mode 100644 index e06fbcfe50..0000000000 --- a/types/jquery-notifier/index.d.ts +++ /dev/null @@ -1,18 +0,0 @@ -// Type definitions for non-npm package notifier 1.0 -// Project: https://github.com/allipierre/jquery-notifier -// Definitions by: Alli Pierre Yotti -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - -declare namespace notifier { - /** - * notifier.show(title, msg, type, icon, timeout); - * {title} title - * {msg} msg - * {type} type - * {icon} icon - * {timeout} timeout - */ - function show(title: string, msg: string, type: string, icon: string, timeout?: number): string | number; - - function hide(notificationId: string | number): boolean; -} diff --git a/types/jquery-notifier/jquery-notifier-tests.ts b/types/jquery-notifier/jquery-notifier-tests.ts deleted file mode 100644 index 18804758be..0000000000 --- a/types/jquery-notifier/jquery-notifier-tests.ts +++ /dev/null @@ -1,31 +0,0 @@ -notifier.show('Hello!', 'I am a default notification.', '', '', 0); -notifier.show('Reminder!', 'You have a meeting at 10:30 AM.', '', '', 0); -notifier.show('Well Done!', 'You just submit your resume successfuly.', '', '', 0); -notifier.show('Warning!', 'The data presented here can be change.', '', '', 0); -notifier.show('Sorry!', 'Could not complete your transaction.', '', '', 0); - -notifier.show('Default!', 'I am a default notification.', '', 'img/clock-48.png', 0); -notifier.show('Reminder!', 'You have a meeting at 10:30 AM.', '', 'img/survey-48.png', 0); -notifier.show('Well Done!', 'You just submit your resume successfuly.', '', 'img/ok-48.png', 0); -notifier.show('Warning!', 'The data presented here can be change.', '', 'img/medium_priority-48.png', 0); -notifier.show('Sorry!', 'Could not complete your transaction.', '', 'img/high_priority-48.png', 0); - -notifier.show('Default!', 'I am a default notification.', '', 'img/clock-48.png', 4000); -notifier.show('Reminder!', 'You have a meeting at 10:30 AM.', '', 'img/survey-48.png', 4000); -notifier.show('Well Done!', 'You just submit your resume successfuly.', '', 'img/ok-48.png', 4000); -notifier.show('Warning!', 'The data presented here can be change.', '', 'img/medium_priority-48.png', 4000); -notifier.show('Sorry!', 'Could not complete your transaction.', '', 'img/high_priority-48.png', 4000); - -let notificationId: string | number; - -let showNotification = () => { - notificationId = notifier.show('Reminder!', 'You have a meeting at 10:30 AM.', '', 'img/survey-48.png', 4000); -}; - -let hideNotification = () => { - notifier.hide(notificationId); -}; - -document.querySelector('#btn-nt-show').addEventListener('click', showNotification); - -document.querySelector('#btn-nt-hide').addEventListener('click', hideNotification); diff --git a/types/jquery-notifier/tsconfig.json b/types/jquery-notifier/tsconfig.json deleted file mode 100644 index 3044613c27..0000000000 --- a/types/jquery-notifier/tsconfig.json +++ /dev/null @@ -1,24 +0,0 @@ -{ - "compilerOptions": { - "module": "commonjs", - "lib": [ - "es6", - "dom" - ], - "noImplicitAny": true, - "noImplicitThis": true, - "strictNullChecks": false, - "strictFunctionTypes": true, - "baseUrl": "../", - "typeRoots": [ - "../" - ], - "types": [], - "noEmit": true, - "forceConsistentCasingInFileNames": true - }, - "files": [ - "index.d.ts", - "jquery-notifier-tests.ts" - ] -} \ No newline at end of file diff --git a/types/jquery-notifier/tslint.json b/types/jquery-notifier/tslint.json deleted file mode 100644 index 3db14f85ea..0000000000 --- a/types/jquery-notifier/tslint.json +++ /dev/null @@ -1 +0,0 @@ -{ "extends": "dtslint/dt.json" } diff --git a/types/natsort/index.d.ts b/types/natsort/index.d.ts index bf448f218d..24c9258187 100644 --- a/types/natsort/index.d.ts +++ b/types/natsort/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for natsort 1.0 -// Project: https://github.com/bubkoo/natsort +// Project: https://github.com/netop/natsort // Definitions by: Melvin Groenhoff // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped diff --git a/types/react-instantsearch-core/index.d.ts b/types/react-instantsearch-core/index.d.ts index bc968f519d..64375d6e20 100644 --- a/types/react-instantsearch-core/index.d.ts +++ b/types/react-instantsearch-core/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for react-instantsearch-core 5.2 -// Project: https://community.algolia.com/react-instantsearch/ +// Project: https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/react, https://community.algolia.com/react-instantsearch/ // Definitions by: Gordon Burgett // Justin Powell // David Furlong diff --git a/types/react-instantsearch-dom/index.d.ts b/types/react-instantsearch-dom/index.d.ts index 6f270485b3..c1cf8ba331 100644 --- a/types/react-instantsearch-dom/index.d.ts +++ b/types/react-instantsearch-dom/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for react-instantsearch 5.2 -// Project: https://community.algolia.com/react-instantsearch/ +// Project: https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/react, https://community.algolia.com/react-instantsearch/ // Definitions by: Gordon Burgett // Justin Powell // Haroen Viaene diff --git a/types/react-instantsearch-native/index.d.ts b/types/react-instantsearch-native/index.d.ts index 74933ebabf..f75f8a4e5b 100644 --- a/types/react-instantsearch-native/index.d.ts +++ b/types/react-instantsearch-native/index.d.ts @@ -1,5 +1,5 @@ // Type definitions for react-instantsearch-native 5.3 -// Project: https://community.algolia.com/react-instantsearch +// Project: https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/react, https://community.algolia.com/react-instantsearch // Definitions by: Gordon Burgett // Justin Powell // Haroen Viaene diff --git a/types/react-test-renderer/react-test-renderer-tests.ts b/types/react-test-renderer/react-test-renderer-tests.ts index f8bcb14d2d..7a7cb5c8f1 100644 --- a/types/react-test-renderer/react-test-renderer-tests.ts +++ b/types/react-test-renderer/react-test-renderer-tests.ts @@ -48,7 +48,7 @@ function testInstance(inst: ReactTestInstance) { testInstance(inst.findByProps({ prop1: "p" })); testInstance(inst.findByType("a")); testInstance(inst.findByType(TestComponent)); - inst.findAll(n => n.type === "t", { deep: true }).map(testInstance); + inst.findAll(n => n.type === "div", { deep: true }).map(testInstance); inst.findAllByProps({ prop1: "p" }, { deep: true }).map(testInstance); inst.findAllByType("a", { deep: true }).map(testInstance); inst.findAllByType(TestComponent, { deep: true }).map(testInstance);