From 33d0fe9dfd550eaffda91c5510459e4a5dd5b4de Mon Sep 17 00:00:00 2001 From: Daniel Hritzkiv Date: Wed, 16 Jan 2019 16:05:38 -0500 Subject: [PATCH 1/4] [bull] Add additional job properties including: queue, name, and stracktrace Rationale: it is useful to know which queue (and named processor) this Job was in. --- types/bull/index.d.ts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/types/bull/index.d.ts b/types/bull/index.d.ts index 2419afee8f..aa1ae89273 100644 --- a/types/bull/index.d.ts +++ b/types/bull/index.d.ts @@ -128,6 +128,25 @@ declare namespace Bull { * When this job was completed (unix milliseconds) */ finishedOn?: number; + + /** + * Which queue this job was part of + */ + queue: Queue; + + timestamp: number; + + /** + * The named processor name + */ + name: string; + + /** + * The stacktrace for any errors + */ + stacktrace: string[]; + + returnvalue: any; /** * Report progress on a job From ff5cc58a47a24c7b9d1147d572837f0054dad7a6 Mon Sep 17 00:00:00 2001 From: Daniel Hritzkiv Date: Wed, 16 Jan 2019 16:37:00 -0500 Subject: [PATCH 2/4] Update index.d.ts Remove whitespace --- types/bull/index.d.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/types/bull/index.d.ts b/types/bull/index.d.ts index aa1ae89273..430886b764 100644 --- a/types/bull/index.d.ts +++ b/types/bull/index.d.ts @@ -128,24 +128,24 @@ declare namespace Bull { * When this job was completed (unix milliseconds) */ finishedOn?: number; - + /** * Which queue this job was part of */ queue: Queue; - + timestamp: number; - + /** * The named processor name */ name: string; - + /** * The stacktrace for any errors */ stacktrace: string[]; - + returnvalue: any; /** From e49d357d1d04b55b1ea2f5ba7fd2b75610037d2e Mon Sep 17 00:00:00 2001 From: Daniel Hritzkiv Date: Wed, 16 Jan 2019 20:42:32 -0500 Subject: [PATCH 3/4] Update index.d.ts Mark returnvalue as nullable --- types/bull/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/bull/index.d.ts b/types/bull/index.d.ts index 430886b764..361bece39b 100644 --- a/types/bull/index.d.ts +++ b/types/bull/index.d.ts @@ -146,7 +146,7 @@ declare namespace Bull { */ stacktrace: string[]; - returnvalue: any; + returnvalue: any | null; /** * Report progress on a job From 7159e5a15bb42d1e1cefedfed829beff5016cb59 Mon Sep 17 00:00:00 2001 From: Daniel Hritzkiv Date: Thu, 17 Jan 2019 11:07:28 -0500 Subject: [PATCH 4/4] Update index.d.ts Remove nullable from returnvalue (as any already encompasses null) --- types/bull/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/bull/index.d.ts b/types/bull/index.d.ts index 361bece39b..430886b764 100644 --- a/types/bull/index.d.ts +++ b/types/bull/index.d.ts @@ -146,7 +146,7 @@ declare namespace Bull { */ stacktrace: string[]; - returnvalue: any | null; + returnvalue: any; /** * Report progress on a job