diff --git a/types/minio/index.d.ts b/types/minio/index.d.ts index e4f2a0613c..7e920428ff 100644 --- a/types/minio/index.d.ts +++ b/types/minio/index.d.ts @@ -10,7 +10,7 @@ import { Stream } from 'stream'; import EventEmitter = NodeJS.EventEmitter; // Exports only from typings -export type Region = 'us-east-1'|'us-west-1'|'us-west-2'|'eu-west-1'|'eu-central-1'|'ap-southeast-1'|'ap-northeast-1'|'ap-southeast-2'|'sa-east-1'|'cn-north-1'; +export type Region = 'us-east-1'|'us-west-1'|'us-west-2'|'eu-west-1'|'eu-central-1'|'ap-southeast-1'|'ap-northeast-1'|'ap-southeast-2'|'sa-east-1'|'cn-north-1'|string; export type PolicyValue = 'none'|'readonly'|'writeonly'|'readwrite'; export type NoResultCallback = (error: Error|null) => void; export type ResultCallback = (error: Error|null, result: T) => void; @@ -46,8 +46,7 @@ export interface BucketItemStat { size: number; contentType: string; etag: string; - // In documentation in this case string. Is it doc error? - lastModified: Date|string; + lastModified: string; } export interface IncompleteUploadedBucketItem { @@ -80,14 +79,12 @@ export class Client { constructor(options: ClientOptions); // Bucket operations - makeBucket(bucketName: string, callback: NoResultCallback): void; makeBucket(bucketName: string, region: Region, callback: NoResultCallback): void; - makeBucket(bucketName: string, region?: Region): Promise; + makeBucket(bucketName: string, region: Region): Promise; listBuckets(callback: ResultCallback): void; listBuckets(): Promise; - // Doc contains error - no boolean value in result bucketExists(bucketName: string, callback: NoResultCallback): void; bucketExists(bucketName: string): Promise; diff --git a/types/minio/minio-tests.ts b/types/minio/minio-tests.ts index 56e81762ce..78a7fab267 100644 --- a/types/minio/minio-tests.ts +++ b/types/minio/minio-tests.ts @@ -9,10 +9,9 @@ const minio = new Minio.Client({ secretKey: 'Go1hhOkXnl', }); -minio.makeBucket('testBucket', (error: Error|null) => { console.log(error); }); minio.makeBucket('testBucket', 'ap-southeast-2', (error: Error|null) => { console.log(error); }); -minio.makeBucket('testBucket'); minio.makeBucket('testBucket', 'eu-west-1'); +minio.makeBucket('testBucket', 'region-not-from-list'); minio.listBuckets((error: Error|null, bucketList: Minio.BucketItemFromList[]) => { console.log(error, bucketList); }); minio.listBuckets();