From 8b88d55ef1a463e398ccd5105b5838f953ffa511 Mon Sep 17 00:00:00 2001 From: Eugen Podaru Date: Mon, 28 Sep 2015 15:13:49 +0200 Subject: [PATCH 1/2] Changed IFilterPredicateFunc to return boolean instead of T[] as per angular docs (https://docs.angularjs.org/api/ng/filter/filter) --- angularjs/angular.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/angularjs/angular.d.ts b/angularjs/angular.d.ts index 9f7fa07b00..6e42cabf5e 100644 --- a/angularjs/angular.d.ts +++ b/angularjs/angular.d.ts @@ -794,7 +794,7 @@ declare module angular { } interface IFilterPredicateFunc { - (value: T, index: number, array: T[]): T[]; + (value: T, index: number, array: T[]): boolean; } interface IFilterComparatorFunc { From 492c22b1761f0e70e2b07de600ed882355339ad1 Mon Sep 17 00:00:00 2001 From: Eugen Podaru Date: Mon, 28 Sep 2015 15:30:05 +0200 Subject: [PATCH 2/2] Fix the tests to comply with the interface --- angularjs/angular-tests.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/angularjs/angular-tests.ts b/angularjs/angular-tests.ts index 0174a0d616..7fe9271d99 100644 --- a/angularjs/angular-tests.ts +++ b/angularjs/angular-tests.ts @@ -941,10 +941,10 @@ function ngFilterTyping() { $filter("name")(items, "test"); $filter("name")(items, {name: "test"}); $filter("name")(items, (val, index, array) => { - return array; + return true; }); $filter("name")(items, (val, index, array) => { - return array; + return true; }, (actual, expected) => { return actual == expected; });