From 8dfd127a63ef1e62e7763ef909e902f71429c3ac Mon Sep 17 00:00:00 2001 From: Dan Rumney Date: Tue, 14 May 2019 16:36:16 -0500 Subject: [PATCH] [Sequelize]: `scope` should be supported for all association types (#35420) * [Sequelize]: Adding support for association scopes on all associations * [Sequelize]: Adding support for association scopes on all associations --- types/sequelize/index.d.ts | 2 ++ types/sequelize/sequelize-tests.ts | 1 + 2 files changed, 3 insertions(+) diff --git a/types/sequelize/index.d.ts b/types/sequelize/index.d.ts index c7d5c9a80d..897d9e4860 100644 --- a/types/sequelize/index.d.ts +++ b/types/sequelize/index.d.ts @@ -18,6 +18,7 @@ // Dima Smirnov // Duy Truong // Emmanuel Gautier +// Dan Rumney // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 @@ -1273,6 +1274,7 @@ declare namespace sequelize { constraints?: boolean; foreignKeyConstraint?: boolean; + scope?: AssociationScope; } /** diff --git a/types/sequelize/sequelize-tests.ts b/types/sequelize/sequelize-tests.ts index 50500df8de..ceb98dc773 100644 --- a/types/sequelize/sequelize-tests.ts +++ b/types/sequelize/sequelize-tests.ts @@ -136,6 +136,7 @@ User.hasMany( User, { foreignKey : 'parent', foreignKeyConstraint : true } ); +User.hasOne( Task, { foreignKey : 'userId', as : 'activeTasks', scope : { active : true } } ); User.belongsToMany( Task, { through : 'UserTasks' } ); User.belongsToMany( User, { through : Task } );