From 78ee0172b8188a39ed345c8be7b4904cf915a8c8 Mon Sep 17 00:00:00 2001 From: Alex Vidrean Date: Mon, 15 Oct 2018 17:05:23 +0300 Subject: [PATCH 1/5] Closes #29308 --- types/googlemaps/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/googlemaps/index.d.ts b/types/googlemaps/index.d.ts index 722a2ff819..8f5d55a455 100644 --- a/types/googlemaps/index.d.ts +++ b/types/googlemaps/index.d.ts @@ -2881,7 +2881,7 @@ declare namespace google.maps { export interface FindPlaceFromPhoneNumberRequest { fields: string[]; locationBias?: LocationBias; - query: string; + phoneNumber: string; } } From f80ec98d062f3a07544fde669c7f5634f40800f5 Mon Sep 17 00:00:00 2001 From: Alex Vidrean Date: Mon, 15 Oct 2018 17:15:54 +0300 Subject: [PATCH 2/5] Changed parameter `query` to `phoneNumber` in googlemaps service. Closes #29308 --- types/googlemaps/googlemaps-tests.ts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/types/googlemaps/googlemaps-tests.ts b/types/googlemaps/googlemaps-tests.ts index e161e8068e..ac7217dd17 100644 --- a/types/googlemaps/googlemaps-tests.ts +++ b/types/googlemaps/googlemaps-tests.ts @@ -438,3 +438,14 @@ service.findPlaceFromQuery({ results[0].name; // $ExpectType string }); + +service.findPlaceFromPhoneNumber({ + phoneNumber: '123456', + fields: ['name'] +}, (results, status) => { + if (status === google.maps.places.PlacesServiceStatus.ERROR) { + return; + } + + results[0].name; // $ExpectType string +}); From c57d941a9f9521aa7c9588fe9543308cc93d65b3 Mon Sep 17 00:00:00 2001 From: Alex Vidrean Date: Sun, 21 Oct 2018 22:40:08 +0300 Subject: [PATCH 3/5] Changed executeSync `params` parameter to optional Closes: #29844 --- types/ibm_db/ibm_db-tests.ts | 14 ++++++++++++++ types/ibm_db/index.d.ts | 4 ++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/types/ibm_db/ibm_db-tests.ts b/types/ibm_db/ibm_db-tests.ts index 93802c662f..3c86affa7e 100644 --- a/types/ibm_db/ibm_db-tests.ts +++ b/types/ibm_db/ibm_db-tests.ts @@ -10,3 +10,17 @@ ibmdb.open("DATABASE=;HOSTNAME=;UID=db2user;PWD=password;PORT= void): void; - _executeSync(params: any[]): ODBCResult; + _executeSync(params?: any[]): ODBCResult; _executeDirect(sql: string, cb: (err: Error, result: any[]) => void): void; @@ -170,7 +170,7 @@ export class ODBCStatement { execute(cb: (err: Error, result: any[], outparams: any) => void): void; execute(params: any[]): Promise<{result: any[], outparams: any}>; - executeSync(params: any[]): ODBCResult; + executeSync(params?: any[]): ODBCResult; executeDirect(sql: string, cb: (err: Error, result: any[]) => void): void; From 38637cf1935884802183cdf94a9f90631a3d9b5c Mon Sep 17 00:00:00 2001 From: Alex Vidrean Date: Sun, 21 Oct 2018 23:17:03 +0300 Subject: [PATCH 4/5] Revert "Changed executeSync `params` parameter to optional Closes: #29844" This reverts commit c57d941a9f9521aa7c9588fe9543308cc93d65b3. --- types/ibm_db/ibm_db-tests.ts | 14 -------------- types/ibm_db/index.d.ts | 4 ++-- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/types/ibm_db/ibm_db-tests.ts b/types/ibm_db/ibm_db-tests.ts index 3c86affa7e..93802c662f 100644 --- a/types/ibm_db/ibm_db-tests.ts +++ b/types/ibm_db/ibm_db-tests.ts @@ -10,17 +10,3 @@ ibmdb.open("DATABASE=;HOSTNAME=;UID=db2user;PWD=password;PORT= void): void; - _executeSync(params?: any[]): ODBCResult; + _executeSync(params: any[]): ODBCResult; _executeDirect(sql: string, cb: (err: Error, result: any[]) => void): void; @@ -170,7 +170,7 @@ export class ODBCStatement { execute(cb: (err: Error, result: any[], outparams: any) => void): void; execute(params: any[]): Promise<{result: any[], outparams: any}>; - executeSync(params?: any[]): ODBCResult; + executeSync(params: any[]): ODBCResult; executeDirect(sql: string, cb: (err: Error, result: any[]) => void): void; From 5de6e9c58492a35ea262a4fbba4a03cbe5f93ba5 Mon Sep 17 00:00:00 2001 From: Alex Vidrean Date: Fri, 26 Oct 2018 19:13:32 +0300 Subject: [PATCH 5/5] Changed executeSync `params` parameter to optional Closes: #29844 --- types/ibm_db/ibm_db-tests.ts | 11 +++++++++++ types/ibm_db/index.d.ts | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/types/ibm_db/ibm_db-tests.ts b/types/ibm_db/ibm_db-tests.ts index 93802c662f..cc896b8d05 100644 --- a/types/ibm_db/ibm_db-tests.ts +++ b/types/ibm_db/ibm_db-tests.ts @@ -10,3 +10,14 @@ ibmdb.open("DATABASE=;HOSTNAME=;UID=db2user;PWD=password;PORT= void): void; - _executeSync(params: any[]): ODBCResult; + _executeSync(params?: any[]): ODBCResult; _executeDirect(sql: string, cb: (err: Error, result: any[]) => void): void; @@ -170,7 +170,7 @@ export class ODBCStatement { execute(cb: (err: Error, result: any[], outparams: any) => void): void; execute(params: any[]): Promise<{result: any[], outparams: any}>; - executeSync(params: any[]): ODBCResult; + executeSync(params?: any[]): ODBCResult; executeDirect(sql: string, cb: (err: Error, result: any[]) => void): void;