From 962bd3a27382a5164f5aec29a42e7c5f4f6eca36 Mon Sep 17 00:00:00 2001 From: Chris Grigg Date: Tue, 27 Dec 2016 19:43:08 -0500 Subject: [PATCH] Correct @types/three TubeGeometry path argument (#13475) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Despite being called "path," `TubeGeometry` requires a Vector3 curve. I think this came from someone misreading the docs (https://threejs.org/docs/#Reference/Geometries/TubeGeometry), where it identifies the first argument like this: ``` path — Curve - A path that inherits from the Curve base class ``` The "Curve" in the description links to https://threejs.org/docs/#Reference/Extras.Core/Curve. A `Path`, meanwhile, comes from a list of Vector2s, which seems totally incompatible. --- three/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/three/index.d.ts b/three/index.d.ts index a7da5b8c10..383c4e2aa7 100644 --- a/three/index.d.ts +++ b/three/index.d.ts @@ -6483,10 +6483,10 @@ declare namespace THREE { } export class TubeGeometry extends Geometry { - constructor(path: Path, segments?: number, radius?: number, radiusSegments?: number, closed?: boolean, taper?: (u: number) => number); + constructor(path: Curve, segments?: number, radius?: number, radiusSegments?: number, closed?: boolean, taper?: (u: number) => number); parameters: { - path: Path; + path: Curve; segments: number; radius: number; radialSegments: number;