From 79a7a816153e8632254dc018609264ba0a8ce35a Mon Sep 17 00:00:00 2001 From: Cosnomi Date: Tue, 12 Feb 2019 19:03:25 +0900 Subject: [PATCH 1/2] recharts: Allow dataKey function to return string --- types/recharts/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/recharts/index.d.ts b/types/recharts/index.d.ts index fc127e9251..97cfdc64fe 100644 --- a/types/recharts/index.d.ts +++ b/types/recharts/index.d.ts @@ -13,6 +13,7 @@ // Andrew Palugniok // Robert Stigsson // Kosaku Kurino +// Kanato Masayoshi // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 @@ -30,7 +31,7 @@ export type TooltipFormatter = (value: string | number | Array, entry: TooltipPayload, index: number) => React.ReactNode; export type ItemSorter = (a: T, b: T) => number; export type ContentRenderer

= (props: P) => React.ReactNode; -export type DataKey = string | number | ((dataObject: any) => number | [number, number] | null); +export type DataKey = string | number | ((dataObject: any) => string | number | [number, number] | null); export type IconType = 'plainline' | 'line' | 'square' | 'rect' | 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'plainline'; export type LegendType = IconType | 'none'; From 9c154dfba5ad28460771fb244a34dadca32a16fb Mon Sep 17 00:00:00 2001 From: cosnomi <42759138+cosnomi@users.noreply.github.com> Date: Sun, 17 Feb 2019 21:12:52 +0900 Subject: [PATCH 2/2] Remove my name from "definitions by" I realized I should not be listed here as I don't have enough knowledge on recharts to review the coming PRs. --- types/recharts/index.d.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/types/recharts/index.d.ts b/types/recharts/index.d.ts index 97cfdc64fe..16b4af8fb6 100644 --- a/types/recharts/index.d.ts +++ b/types/recharts/index.d.ts @@ -13,7 +13,6 @@ // Andrew Palugniok // Robert Stigsson // Kosaku Kurino -// Kanato Masayoshi // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8