From 9994b4eb4a845ea7c6e8e3f2e1127cd0ed75cb49 Mon Sep 17 00:00:00 2001 From: Andy Date: Thu, 10 Nov 2016 15:20:24 -0800 Subject: [PATCH] Improve PR template (#12517) --- PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 053b2c3eae..a2c9ec9e5b 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,15 @@ Please fill in this template. - [ ] Prefer to make your PR against the `types-2.0` branch. -- [ ] The package does not provide its own types, and you can not add them. - [ ] Test the change in your own code. - [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request). - [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped#common-mistakes). If adding a new definition: +- [ ] The package does not provide its own types, and you can not add them. - [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package. - [ ] Run `tsc` without errors. -- [ ] Include the required [files](https://github.com/DefinitelyTyped/DefinitelyTyped#create-a-new-package) and header. +- [ ] Include the required [files](https://github.com/DefinitelyTyped/DefinitelyTyped#create-a-new-package) and header. Base these on the README, *not* on an existing project. If changing an existing definition: - [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <>