From 99ddd7b2e668d5a75049d52ef5062f5010f55ddc Mon Sep 17 00:00:00 2001 From: Lucas Martin Acosta Date: Thu, 12 Jan 2017 18:46:30 +0200 Subject: [PATCH] [passport-facebook] Add missing optional param in verify callback (#13944) --- passport-facebook/index.d.ts | 6 +++--- passport-facebook/passport-facebook-tests.ts | 10 ++++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/passport-facebook/index.d.ts b/passport-facebook/index.d.ts index f614c98b8d..bcc742dae5 100644 --- a/passport-facebook/index.d.ts +++ b/passport-facebook/index.d.ts @@ -1,6 +1,6 @@ -// Type definitions for passport-facebook 1.0.3 +// Type definitions for passport-facebook 2.1.1 // Project: https://github.com/jaredhanson/passport-facebook -// Definitions by: James Roland Cabresos +// Definitions by: James Roland Cabresos , Lucas Acosta // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped /// @@ -31,7 +31,7 @@ interface IStrategyOption { declare class Strategy implements passport.Strategy { constructor(options: IStrategyOption, - verify: (accessToken: string, refreshToken: string, profile: Profile, done: (error: any, user?: any) => void) => void); + verify: (accessToken: string, refreshToken: string, profile: Profile, done: (error: any, user?: any, info?: any) => void) => void); name: string; authenticate: (req: express.Request, options?: Object) => void; } diff --git a/passport-facebook/passport-facebook-tests.ts b/passport-facebook/passport-facebook-tests.ts index d8d781ff19..6a257661ba 100644 --- a/passport-facebook/passport-facebook-tests.ts +++ b/passport-facebook/passport-facebook-tests.ts @@ -24,3 +24,13 @@ passport.use(new facebook.Strategy({ }); }) ); + +passport.use(new facebook.Strategy({ + clientID: process.env.PASSPORT_FACEBOOK_CLIENT_ID, + clientSecret: process.env.PASSPORT_FACEBOOK_CLIENT_SECRET, + callbackURL: process.env.PASSPORT_FACEBOOK_CALLBACK_URL + }, + function(accessToken:string, refreshToken:string, profile:facebook.Profile, done:(error:any, user?:any, info?:any) => void) { + done(null, false, { message: 'Some error.' }); + }) +);