From 6d81c90395104ca52bfd30e3574bd13f4b39861a Mon Sep 17 00:00:00 2001 From: denis Date: Tue, 24 Jan 2017 15:18:31 +0100 Subject: [PATCH 1/4] MetisMenu: add missing types for 2.6.1 Add events types, preventDefault properties, and 'dispose' option. --- metismenu/index.d.ts | 8 ++++++-- metismenu/metismenu-tests.ts | 19 ++++++++++++++++++- 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/metismenu/index.d.ts b/metismenu/index.d.ts index 43faa279c7..1816090f87 100644 --- a/metismenu/index.d.ts +++ b/metismenu/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for metisMenu 2.0.3 +// Type definitions for metisMenu 2.6.1 // Project: http://github.com/onokumus/metisMenu // Definitions by: onokums // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -12,8 +12,12 @@ interface MetisMenuOptions { collapseClass?: string; collapseInClass?: string; collapsingClass?: string; + preventDefault?: boolean; } +type MetisMenuEvents = "show.metisMenu" | "shown.metisMenu" | "hide.metisMenu" | "hidden.metisMenu"; + interface JQuery { - metisMenu(options?: MetisMenuOptions): JQuery; + metisMenu(options?: MetisMenuOptions | "dispose"): JQuery; + on(events: MetisMenuEvents, handler: (eventObject: JQueryEventObject) => any): JQuery; } diff --git a/metismenu/metismenu-tests.ts b/metismenu/metismenu-tests.ts index b2e36f1d53..625a4877ab 100644 --- a/metismenu/metismenu-tests.ts +++ b/metismenu/metismenu-tests.ts @@ -1,12 +1,29 @@ /// $('#menu').metisMenu(); + $('.metismenu').metisMenu({toggle: false}); + $('.test').metisMenu({ toggle: false, doubleTapToGo: true, activeClass: 'active', collapseClass: 'collapse', collapseInClass: 'in', - collapsingClass: 'collapsing' + collapsingClass: 'collapsing', + preventDefault: true }); + +$('.metismenu').metisMenu('dispose'); + +$('.metismenu') + .metisMenu() + .on('show.metisMenu', function(e) { + // empty logic + }).on('shown.metisMenu', function(e) { + // empty logic + }).on('hide.metisMenu', function(e) { + // empty logic + }).on('hidden.metisMenu', function(e) { + // empty logic + }); From 4750cce5220c94b7ca3ed2c85636f5386cff3690 Mon Sep 17 00:00:00 2001 From: denis Date: Tue, 31 Jan 2017 12:31:18 +0100 Subject: [PATCH 2/4] Changes according to repo owner Truncate version number Add author name --- metismenu/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/metismenu/index.d.ts b/metismenu/index.d.ts index 1816090f87..7b8a8eca19 100644 --- a/metismenu/index.d.ts +++ b/metismenu/index.d.ts @@ -1,6 +1,6 @@ -// Type definitions for metisMenu 2.6.1 +// Type definitions for metisMenu 2.6 // Project: http://github.com/onokumus/metisMenu -// Definitions by: onokums +// Definitions by: onokums , denis // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped /// From 350f4ef001a722315ed4d6cc354bb9a8d7f05605 Mon Sep 17 00:00:00 2001 From: denis Date: Thu, 2 Feb 2017 17:04:55 +0100 Subject: [PATCH 3/4] Remove double tap property The property `doubleTapToGo` was deprecated and is gone in 2.6.2. As 2.6.2 is not backward compatible with previous versions, I set back exact version number in header. --- metismenu/index.d.ts | 3 +-- metismenu/metismenu-tests.ts | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/metismenu/index.d.ts b/metismenu/index.d.ts index 7b8a8eca19..bdd500041f 100644 --- a/metismenu/index.d.ts +++ b/metismenu/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for metisMenu 2.6 +// Type definitions for metisMenu 2.6.2 // Project: http://github.com/onokumus/metisMenu // Definitions by: onokums , denis // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -7,7 +7,6 @@ interface MetisMenuOptions { toggle?: boolean; - doubleTapToGo?: boolean; activeClass?: string; collapseClass?: string; collapseInClass?: string; diff --git a/metismenu/metismenu-tests.ts b/metismenu/metismenu-tests.ts index 625a4877ab..eb17270021 100644 --- a/metismenu/metismenu-tests.ts +++ b/metismenu/metismenu-tests.ts @@ -6,7 +6,6 @@ $('.metismenu').metisMenu({toggle: false}); $('.test').metisMenu({ toggle: false, - doubleTapToGo: true, activeClass: 'active', collapseClass: 'collapse', collapseInClass: 'in', From 7eec158cd5956142788d1f89b65d48eb245e92b4 Mon Sep 17 00:00:00 2001 From: Bowden Kelly Date: Fri, 3 Feb 2017 18:39:05 -0800 Subject: [PATCH 4/4] Update index.d.ts --- metismenu/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metismenu/index.d.ts b/metismenu/index.d.ts index bdd500041f..8117328bf8 100644 --- a/metismenu/index.d.ts +++ b/metismenu/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for metisMenu 2.6.2 +// Type definitions for metisMenu 2.6 // Project: http://github.com/onokumus/metisMenu // Definitions by: onokums , denis // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped