From 9fa36689abc70f09ba9b3f20384c9abcbbabcab5 Mon Sep 17 00:00:00 2001 From: Willem Sonke Date: Sat, 21 Jul 2018 02:57:12 +0200 Subject: [PATCH] [snapsvg] Make handler optional for un... methods (#27252) For `unclick` the handler argument was already marked as optional. As in snapsvg's [implementation of the `un...` methods](https://github.com/adobe-webplatform/Snap.svg/blob/master/src/mouse.js#L340) there is no difference in how the various events are handled, the handler should also be optional for the other event types. I tried this with `undblclick` in particular, and it works as expected (removes all `dblclick` events). --- types/snapsvg/index.d.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/types/snapsvg/index.d.ts b/types/snapsvg/index.d.ts index 981252ac07..c012cc238c 100644 --- a/types/snapsvg/index.d.ts +++ b/types/snapsvg/index.d.ts @@ -203,16 +203,16 @@ declare namespace Snap { touchcancel(handler: (event: MouseEvent) => void, thisArg?: any): Snap.Element; unclick(handler?: (event: MouseEvent) => void): Snap.Element; - undblclick(handler: (event: MouseEvent) => void): Snap.Element; - unmousedown(handler: (event: MouseEvent) => void): Snap.Element; - unmousemove(handler: (event: MouseEvent) => void): Snap.Element; - unmouseout(handler: (event: MouseEvent) => void): Snap.Element; - unmouseover(handler: (event: MouseEvent) => void): Snap.Element; - unmouseup(handler: (event: MouseEvent) => void): Snap.Element; - untouchstart(handler: (event: MouseEvent) => void): Snap.Element; - untouchmove(handler: (event: MouseEvent) => void): Snap.Element; - untouchend(handler: (event: MouseEvent) => void): Snap.Element; - untouchcancel(handler: (event: MouseEvent) => void): Snap.Element; + undblclick(handler?: (event: MouseEvent) => void): Snap.Element; + unmousedown(handler?: (event: MouseEvent) => void): Snap.Element; + unmousemove(handler?: (event: MouseEvent) => void): Snap.Element; + unmouseout(handler?: (event: MouseEvent) => void): Snap.Element; + unmouseover(handler?: (event: MouseEvent) => void): Snap.Element; + unmouseup(handler?: (event: MouseEvent) => void): Snap.Element; + untouchstart(handler?: (event: MouseEvent) => void): Snap.Element; + untouchmove(handler?: (event: MouseEvent) => void): Snap.Element; + untouchend(handler?: (event: MouseEvent) => void): Snap.Element; + untouchcancel(handler?: (event: MouseEvent) => void): Snap.Element; hover(hoverInHandler: (event: MouseEvent) => void, hoverOutHandler: (event: MouseEvent) => void, thisArg?: any): Snap.Element; hover(hoverInHandler: (event: MouseEvent) => void, hoverOutHandler: (event: MouseEvent) => void, inThisArg?: any, outThisArg?: any): Snap.Element;