From e93b36f168c27d4f1a418846f878462935a3666b Mon Sep 17 00:00:00 2001 From: James Russo Date: Fri, 1 Feb 2019 08:05:59 -0500 Subject: [PATCH 1/3] add return type to void functions in definition --- types/sqlanywhere/index.d.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/types/sqlanywhere/index.d.ts b/types/sqlanywhere/index.d.ts index d56bfb7993..5ab3d9ea33 100644 --- a/types/sqlanywhere/index.d.ts +++ b/types/sqlanywhere/index.d.ts @@ -12,16 +12,16 @@ export interface SybaseConnection { close(cb: (err?: Error) => void): void; disconnect(cb: (err?: Error) => void): void; connected(): boolean; - exec(query: string, cb: (err: Error | undefined, result: any) => void); + exec(query: string, cb: (err: Error | undefined, result: any) => void) : void; exec( query: string, placeholders: any[], cb: (err: Error | undefined, result: any) => void - ); + ) : void; prepare( query: string, cb: (err: Error | undefined, stmt: Statement) => void - ); + ) : void; prepare(query: string): Statement; commit(cb: (err: Error | undefined) => void): void; rollback(cb: (err: Error | undefined) => void): void; @@ -37,10 +37,10 @@ export interface ConnectionParameters { } export interface Statement { - exec(args: any[], cb: (err: Error | undefined, rows: any[]) => void); + exec(args: any[], cb: (err: Error | undefined, rows: any[]) => void) : void; exec(args: any[]): any[]; getMoreResults(): any[]; - drop(cb: (err: Error | undefined) => void): void; + drop(cb: (err: Error | undefined) => void) : void; } declare const _default: { createConnection: typeof createConnection; From 37170093c2d5a19f856ed752287f4ae3c6a6d354 Mon Sep 17 00:00:00 2001 From: James Russo Date: Fri, 1 Feb 2019 08:08:26 -0500 Subject: [PATCH 2/3] add updated by header. --- types/sqlanywhere/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/sqlanywhere/index.d.ts b/types/sqlanywhere/index.d.ts index 5ab3d9ea33..e0c292158d 100644 --- a/types/sqlanywhere/index.d.ts +++ b/types/sqlanywhere/index.d.ts @@ -1,6 +1,7 @@ // Type definitions for sqlanywhere 1.0 // Project: https://github.com/sqlanywhere/node-sqlanywhere // Definitions by: Peter Keuter +// Updated by: James Russo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped export function createConnection(): SybaseConnection; From da4d9df6a134cc179b5ec5043cf0734cec4f6815 Mon Sep 17 00:00:00 2001 From: James Russo Date: Fri, 1 Feb 2019 08:14:59 -0500 Subject: [PATCH 3/3] fix lint issues --- types/sqlanywhere/index.d.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/types/sqlanywhere/index.d.ts b/types/sqlanywhere/index.d.ts index e0c292158d..148babd6ec 100644 --- a/types/sqlanywhere/index.d.ts +++ b/types/sqlanywhere/index.d.ts @@ -1,7 +1,6 @@ // Type definitions for sqlanywhere 1.0 // Project: https://github.com/sqlanywhere/node-sqlanywhere // Definitions by: Peter Keuter -// Updated by: James Russo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped export function createConnection(): SybaseConnection; @@ -13,16 +12,16 @@ export interface SybaseConnection { close(cb: (err?: Error) => void): void; disconnect(cb: (err?: Error) => void): void; connected(): boolean; - exec(query: string, cb: (err: Error | undefined, result: any) => void) : void; + exec(query: string, cb: (err: Error | undefined, result: any) => void): void; exec( query: string, placeholders: any[], cb: (err: Error | undefined, result: any) => void - ) : void; + ): void; prepare( query: string, cb: (err: Error | undefined, stmt: Statement) => void - ) : void; + ): void; prepare(query: string): Statement; commit(cb: (err: Error | undefined) => void): void; rollback(cb: (err: Error | undefined) => void): void; @@ -38,10 +37,10 @@ export interface ConnectionParameters { } export interface Statement { - exec(args: any[], cb: (err: Error | undefined, rows: any[]) => void) : void; + exec(args: any[], cb: (err: Error | undefined, rows: any[]) => void): void; exec(args: any[]): any[]; getMoreResults(): any[]; - drop(cb: (err: Error | undefined) => void) : void; + drop(cb: (err: Error | undefined) => void): void; } declare const _default: { createConnection: typeof createConnection;