From a03eae245b363bc41d3aa6ccd227bdca1eb2309f Mon Sep 17 00:00:00 2001 From: Patrick Fitzgerald Date: Mon, 20 Apr 2020 09:24:00 -0700 Subject: [PATCH] [node] change ProcessEnv back to interface to not break custom overrides (#44003) Co-authored-by: Patrick Fitzgerald --- types/node/child_process.d.ts | 2 +- types/node/globals.d.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/types/node/child_process.d.ts b/types/node/child_process.d.ts index c45f3b8507..1cb3f87378 100644 --- a/types/node/child_process.d.ts +++ b/types/node/child_process.d.ts @@ -133,7 +133,7 @@ declare module "child_process" { uid?: number; gid?: number; cwd?: string; - env?: NodeJS.Dict; + env?: NodeJS.ProcessEnv; } interface CommonOptions extends ProcessEnvOptions { diff --git a/types/node/globals.d.ts b/types/node/globals.d.ts index 34764bef38..9a39ac6f7d 100644 --- a/types/node/globals.d.ts +++ b/types/node/globals.d.ts @@ -676,8 +676,8 @@ declare namespace NodeJS { isTTY?: true; } - // Alias for compability - type ProcessEnv = Dict; + // Alias for compatibility + interface ProcessEnv extends Dict {} interface HRTime { (time?: [number, number]): [number, number]; @@ -787,7 +787,7 @@ declare namespace NodeJS { cwd(): string; debugPort: number; emitWarning(warning: string | Error, name?: string, ctor?: Function): void; - env: Dict; + env: ProcessEnv; exit(code?: number): never; exitCode?: number; getgid(): number;