From a13fa7abf55daedf25b31258b908548f55962c7a Mon Sep 17 00:00:00 2001 From: Josh Abernathy Date: Tue, 6 Sep 2016 10:01:03 -0400 Subject: [PATCH] Make React's SyntheticEvent.currentTarget generic over T again (#10784) * Make SyntheticEvent.target generic over T again This change was added in https://github.com/DefinitelyTyped/DefinitelyTyped/commit/084926e23accedcbf700bf480e38abdeabcd971e but then reverted in https://github.com/DefinitelyTyped/DefinitelyTyped/commit/5607f54defce88bc52a0440288f434cafffdb5ce. The revert _looks_ like an accident to me, as it's a merge coming in from master vs. a purposeful change. Maybe it got accidentally stepped on in resolving a conflict? If `target` should no longer be the intersection of `EventTarget` and `T`, then there's not much point to `SyntheticEvent` being generic over `T`. * Make `currentTarget` generic over instead instead of `target` --- react/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/react/index.d.ts b/react/index.d.ts index cb1b567a62..7e300f05aa 100644 --- a/react/index.d.ts +++ b/react/index.d.ts @@ -272,7 +272,7 @@ declare namespace React { interface SyntheticEvent { bubbles: boolean; - currentTarget: EventTarget; + currentTarget: EventTarget & T; cancelable: boolean; defaultPrevented: boolean; eventPhase: number;