From a252b2f7b87ca7230a38a7cc2ff43afb4dace59e Mon Sep 17 00:00:00 2001 From: Quentin Mazars-Simon Date: Wed, 23 Jan 2019 12:30:47 -0500 Subject: [PATCH] add types for exists with callback --- types/ioredis/index.d.ts | 1 + types/ioredis/ioredis-tests.ts | 1 + types/ioredis/v3/index.d.ts | 1 + types/ioredis/v3/ioredis-tests.ts | 1 + 4 files changed, 4 insertions(+) diff --git a/types/ioredis/index.d.ts b/types/ioredis/index.d.ts index ca1d71a0aa..d5f829c8fe 100644 --- a/types/ioredis/index.d.ts +++ b/types/ioredis/index.d.ts @@ -107,6 +107,7 @@ declare namespace IORedis { del(...keys: KeyType[]): Promise; exists(...keys: KeyType[]): Promise; + exists(key: KeyType, callback: (err: Error, res: number) => void): void; setbit(key: KeyType, offset: number, value: any, callback: (err: Error, res: number) => void): void; setbit(key: KeyType, offset: number, value: any): Promise; diff --git a/types/ioredis/ioredis-tests.ts b/types/ioredis/ioredis-tests.ts index 14620b7476..9950a8543f 100644 --- a/types/ioredis/ioredis-tests.ts +++ b/types/ioredis/ioredis-tests.ts @@ -38,6 +38,7 @@ redis.set('key', '100', ['EX', 10, 'NX'], (err, data) => {}); redis.setBuffer('key', '100', 'NX', 'EX', 10, (err, data) => {}); redis.exists('foo').then(result => result * 1); +redis.exists('foo', ((err, data) => data * 1)); // Should support usage of Buffer redis.set(Buffer.from('key'), '100'); diff --git a/types/ioredis/v3/index.d.ts b/types/ioredis/v3/index.d.ts index 03667cd071..b346f7cee3 100644 --- a/types/ioredis/v3/index.d.ts +++ b/types/ioredis/v3/index.d.ts @@ -103,6 +103,7 @@ declare namespace IORedis { del(...keys: string[]): any; exists(...keys: string[]): Promise; + exists(key: string, callback: (err: Error, res: number) => void): void; setbit(key: string, offset: number, value: any, callback: (err: Error, res: number) => void): void; setbit(key: string, offset: number, value: any): Promise; diff --git a/types/ioredis/v3/ioredis-tests.ts b/types/ioredis/v3/ioredis-tests.ts index 38cef49b73..6c16a338ea 100644 --- a/types/ioredis/v3/ioredis-tests.ts +++ b/types/ioredis/v3/ioredis-tests.ts @@ -32,6 +32,7 @@ redis.set('key', '100', ['EX', 10, 'NX'], (err, data) => {}); redis.setBuffer('key', '100', 'NX', 'EX', 10, (err, data) => {}); redis.exists('foo').then(result => result * 1); +redis.exists('foo', ((err, data) => data * 1)); new Redis(); // Connect to 127.0.0.1:6379 new Redis(6380); // 127.0.0.1:6380