From a298ed59c8463bfcce03b04b0e00416151e732e8 Mon Sep 17 00:00:00 2001 From: Xzas22 <37516851+Xzas22@users.noreply.github.com> Date: Fri, 20 Dec 2019 01:10:31 -0500 Subject: [PATCH] Updated CookieOptions.sameSite to correctly reflect new change to @types/express-session (#41038) The change to express-session on Nov 18th (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/40314) broke type checking for connect-redis and express-session. Specifically: Type 'string | boolean | undefined' is not assignable to type 'boolean | "lax" | "strict" | "none" | undefined' --- types/express-serve-static-core/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/express-serve-static-core/index.d.ts b/types/express-serve-static-core/index.d.ts index dc77fbc4d0..519dbbbb87 100644 --- a/types/express-serve-static-core/index.d.ts +++ b/types/express-serve-static-core/index.d.ts @@ -185,7 +185,7 @@ export interface CookieOptions { domain?: string; secure?: boolean; encode?: (val: string) => string; - sameSite?: boolean | string; + sameSite?: boolean | 'lax' | 'strict' | 'none'; } export interface ByteRange { start: number; end: number; }