From a31c3dd12f6457b6b4e5d45b1f63475f4e04717c Mon Sep 17 00:00:00 2001 From: Andy Date: Thu, 5 Jan 2017 11:23:53 -0800 Subject: [PATCH] Clarify pull request template: new packages must be linted (#13760) --- PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 68f322eddc..4d9a7aab6f 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -14,6 +14,7 @@ If adding a new definition: - [ ] The package does not provide its own types, and you can not add them. - [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package. - [ ] Create it with `npm run new-package package-name`, not by basing it on an existing project. +- [ ] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, and `strictNullChecks` set to `true`. If changing an existing definition: - [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <>