From cfdcd0cb154f1abf23cf9b83c8feea1742596f05 Mon Sep 17 00:00:00 2001 From: racerhere Date: Wed, 6 Feb 2019 11:17:26 -0600 Subject: [PATCH 1/6] [kissfft-js]: add type declarations for kissfft-js --- types/kissfft-js/index.d.ts | 17 +++++++++++++++++ types/kissfft-js/kissfft-js-tests.ts | 12 ++++++++++++ types/kissfft-js/tsconfig.json | 22 ++++++++++++++++++++++ types/kissfft-js/tslint.json | 1 + 4 files changed, 52 insertions(+) create mode 100644 types/kissfft-js/index.d.ts create mode 100644 types/kissfft-js/kissfft-js-tests.ts create mode 100644 types/kissfft-js/tsconfig.json create mode 100644 types/kissfft-js/tslint.json diff --git a/types/kissfft-js/index.d.ts b/types/kissfft-js/index.d.ts new file mode 100644 index 0000000000..11f41a3505 --- /dev/null +++ b/types/kissfft-js/index.d.ts @@ -0,0 +1,17 @@ +// Type definitions for kissfft-js 0.1 +// Project: https://github.com/j-funk/kissfft-js#readme +// Definitions by: racerhere +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/types/kissfft-js + +declare abstract class AbstractKissFFT { + constructor(size: number); + forward(input: number[]): number[]; + inverse(input: number[]): number[]; + dispose(): void; +} + +export class FFT extends AbstractKissFFT { +} + +export class FFTR extends AbstractKissFFT { +} diff --git a/types/kissfft-js/kissfft-js-tests.ts b/types/kissfft-js/kissfft-js-tests.ts new file mode 100644 index 0000000000..76c0da2001 --- /dev/null +++ b/types/kissfft-js/kissfft-js-tests.ts @@ -0,0 +1,12 @@ +import {FFT} from "kissfft-js"; +import {FFTR} from "kissfft-js"; + +const fft = new FFT(0); // $ExpectType FFT +fft.forward([1, 2, 3]); // $ExpectType number[] +fft.inverse([1, 2, 3]); // $ExpectType number[] +fft.dispose(); // $ExpectType void + +const fftr = new FFTR(0); // $ExpectType FFTR +fftr.forward([1, 2, 3]); // $ExpectType number[] +fftr.inverse([1, 2, 3]); // $ExpectType number[] +fftr.dispose(); // $ExpectType void diff --git a/types/kissfft-js/tsconfig.json b/types/kissfft-js/tsconfig.json new file mode 100644 index 0000000000..5dfeddfade --- /dev/null +++ b/types/kissfft-js/tsconfig.json @@ -0,0 +1,22 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "kissfft-js-tests.ts" + ] +} diff --git a/types/kissfft-js/tslint.json b/types/kissfft-js/tslint.json new file mode 100644 index 0000000000..3db14f85ea --- /dev/null +++ b/types/kissfft-js/tslint.json @@ -0,0 +1 @@ +{ "extends": "dtslint/dt.json" } From 14e3e2b16793f34e0e0525494a192a532ca5e540 Mon Sep 17 00:00:00 2001 From: racerhere Date: Wed, 6 Feb 2019 11:28:01 -0600 Subject: [PATCH 2/6] [kissfft-js] update tests --- types/kissfft-js/kissfft-js-tests.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/types/kissfft-js/kissfft-js-tests.ts b/types/kissfft-js/kissfft-js-tests.ts index 76c0da2001..7de3255660 100644 --- a/types/kissfft-js/kissfft-js-tests.ts +++ b/types/kissfft-js/kissfft-js-tests.ts @@ -1,12 +1,11 @@ -import {FFT} from "kissfft-js"; -import {FFTR} from "kissfft-js"; +import * as kissFFT from "kissfft-js"; -const fft = new FFT(0); // $ExpectType FFT +const fft = new kissFFT.FFT(0); // $ExpectType FFT fft.forward([1, 2, 3]); // $ExpectType number[] fft.inverse([1, 2, 3]); // $ExpectType number[] fft.dispose(); // $ExpectType void -const fftr = new FFTR(0); // $ExpectType FFTR +const fftr = new kissFFT.FFTR(0); // $ExpectType FFTR fftr.forward([1, 2, 3]); // $ExpectType number[] fftr.inverse([1, 2, 3]); // $ExpectType number[] fftr.dispose(); // $ExpectType void From 97515160efdb573a8e76ae4c73d49b17d817727c Mon Sep 17 00:00:00 2001 From: racerhere Date: Wed, 6 Feb 2019 12:46:54 -0600 Subject: [PATCH 3/6] [kissfft-js] enable strictFunctionTypes check --- types/kissfft-js/tsconfig.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/kissfft-js/tsconfig.json b/types/kissfft-js/tsconfig.json index 5dfeddfade..5164a8f4bd 100644 --- a/types/kissfft-js/tsconfig.json +++ b/types/kissfft-js/tsconfig.json @@ -13,7 +13,8 @@ ], "types": [], "noEmit": true, - "forceConsistentCasingInFileNames": true + "forceConsistentCasingInFileNames": true, + "strictFunctionTypes": true }, "files": [ "index.d.ts", From ff0e1f5aa0ddac9c1ae12797bcbcf0ab1fae98aa Mon Sep 17 00:00:00 2001 From: racerhere Date: Wed, 6 Feb 2019 12:50:22 -0600 Subject: [PATCH 4/6] [kissfft-js] fix lint rule strict-export-declare-modifiers --- types/kissfft-js/index.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/types/kissfft-js/index.d.ts b/types/kissfft-js/index.d.ts index 11f41a3505..14977f7aaa 100644 --- a/types/kissfft-js/index.d.ts +++ b/types/kissfft-js/index.d.ts @@ -15,3 +15,5 @@ export class FFT extends AbstractKissFFT { export class FFTR extends AbstractKissFFT { } + +export {} From fd72fae91ed6e896dbcf9802504aab3507dd02d8 Mon Sep 17 00:00:00 2001 From: racerhere Date: Wed, 6 Feb 2019 12:53:03 -0600 Subject: [PATCH 5/6] [kissfft-js] comply to strict-export-declare-modifiers lint rule --- types/kissfft-js/index.d.ts | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/types/kissfft-js/index.d.ts b/types/kissfft-js/index.d.ts index 14977f7aaa..f03119e4f5 100644 --- a/types/kissfft-js/index.d.ts +++ b/types/kissfft-js/index.d.ts @@ -3,17 +3,16 @@ // Definitions by: racerhere // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped/types/kissfft-js -declare abstract class AbstractKissFFT { +export class FFT { constructor(size: number); forward(input: number[]): number[]; inverse(input: number[]): number[]; dispose(): void; } -export class FFT extends AbstractKissFFT { -} - -export class FFTR extends AbstractKissFFT { -} - -export {} +export class FFTR { + constructor(size: number); + forward(input: number[]): number[]; + inverse(input: number[]): number[]; + dispose(): void; +} \ No newline at end of file From b27226fdf1f5f87594d113ad695057a88eae1376 Mon Sep 17 00:00:00 2001 From: racerhere Date: Wed, 6 Feb 2019 12:54:31 -0600 Subject: [PATCH 6/6] [kissfft-js] comply to eofline lint rule --- types/kissfft-js/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/kissfft-js/index.d.ts b/types/kissfft-js/index.d.ts index f03119e4f5..dc745354ec 100644 --- a/types/kissfft-js/index.d.ts +++ b/types/kissfft-js/index.d.ts @@ -15,4 +15,4 @@ export class FFTR { forward(input: number[]): number[]; inverse(input: number[]): number[]; dispose(): void; -} \ No newline at end of file +}