From 1cb13b7179f16845d5da3c99e00e06eafcf9eb54 Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 4 Feb 2019 11:07:51 +0100 Subject: [PATCH 01/11] Adds elo-rank typings --- types/elo-rank/elo-rank-tests.ts | 7 +++++++ types/elo-rank/index.d.ts | 14 ++++++++++++++ types/elo-rank/tsconfig.json | 22 ++++++++++++++++++++++ types/elo-rank/tslint.json | 1 + 4 files changed, 44 insertions(+) create mode 100644 types/elo-rank/elo-rank-tests.ts create mode 100644 types/elo-rank/index.d.ts create mode 100644 types/elo-rank/tsconfig.json create mode 100644 types/elo-rank/tslint.json diff --git a/types/elo-rank/elo-rank-tests.ts b/types/elo-rank/elo-rank-tests.ts new file mode 100644 index 0000000000..7cf7955a14 --- /dev/null +++ b/types/elo-rank/elo-rank-tests.ts @@ -0,0 +1,7 @@ +import EloRank from 'elo-rank'; + +var test = new EloRank(); + +test.getKFactor(); // $ExpectType number +test.getExpected(1200, 1500); // $ExpectType number +test.updateRating(test.getExpected(1200, 1500), 1300, 1500); // $ExpectType number \ No newline at end of file diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts new file mode 100644 index 0000000000..c2a797cbcb --- /dev/null +++ b/types/elo-rank/index.d.ts @@ -0,0 +1,14 @@ +// Type definitions for elo-rank 1.0 +// Project: https://github.com/dmamills/elo-rank#readme +// Definitions by: Antonio Pavlinovic +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +export class EloRank { + constructor(kFactor?: number); + + setKFactor(kFactor: number): void; + getKFactor(): number; + getExpected(a: number, b: number): number; + + updateRating(expected: number, actual: number, current: number): number; +} diff --git a/types/elo-rank/tsconfig.json b/types/elo-rank/tsconfig.json new file mode 100644 index 0000000000..7ec166bf13 --- /dev/null +++ b/types/elo-rank/tsconfig.json @@ -0,0 +1,22 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "elo-rank-tests.ts" + ] +} diff --git a/types/elo-rank/tslint.json b/types/elo-rank/tslint.json new file mode 100644 index 0000000000..3db14f85ea --- /dev/null +++ b/types/elo-rank/tslint.json @@ -0,0 +1 @@ +{ "extends": "dtslint/dt.json" } From 04a782f4b0342f452ce09ee8cd39af8563ee1a52 Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 4 Feb 2019 12:11:30 +0100 Subject: [PATCH 02/11] strictFunctionTypes set to true --- types/elo-rank/index.d.ts | 2 +- types/elo-rank/tsconfig.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index c2a797cbcb..d3265cb15b 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -3,7 +3,7 @@ // Definitions by: Antonio Pavlinovic // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -export class EloRank { +export default class EloRank { constructor(kFactor?: number); setKFactor(kFactor: number): void; diff --git a/types/elo-rank/tsconfig.json b/types/elo-rank/tsconfig.json index 7ec166bf13..2ebd08f352 100644 --- a/types/elo-rank/tsconfig.json +++ b/types/elo-rank/tsconfig.json @@ -7,6 +7,7 @@ "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": true, + "strictFunctionTypes": true, "baseUrl": "../", "typeRoots": [ "../" From 8ab5b5ff732a1d9a8cc47c3a11c08e2a36c7b31e Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 4 Feb 2019 12:18:03 +0100 Subject: [PATCH 03/11] Fixing lint errors --- types/elo-rank/elo-rank-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/elo-rank/elo-rank-tests.ts b/types/elo-rank/elo-rank-tests.ts index 7cf7955a14..ce5f70dd2e 100644 --- a/types/elo-rank/elo-rank-tests.ts +++ b/types/elo-rank/elo-rank-tests.ts @@ -1,6 +1,6 @@ import EloRank from 'elo-rank'; -var test = new EloRank(); +const test = new EloRank(); test.getKFactor(); // $ExpectType number test.getExpected(1200, 1500); // $ExpectType number From cdd038c9d44acf8f20fe31233c66be4fab8e16f3 Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 4 Feb 2019 12:20:24 +0100 Subject: [PATCH 04/11] Fix tslint errors --- types/elo-rank/elo-rank-tests.ts | 2 +- types/elo-rank/index.d.ts | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/types/elo-rank/elo-rank-tests.ts b/types/elo-rank/elo-rank-tests.ts index ce5f70dd2e..2d3c40ad14 100644 --- a/types/elo-rank/elo-rank-tests.ts +++ b/types/elo-rank/elo-rank-tests.ts @@ -4,4 +4,4 @@ const test = new EloRank(); test.getKFactor(); // $ExpectType number test.getExpected(1200, 1500); // $ExpectType number -test.updateRating(test.getExpected(1200, 1500), 1300, 1500); // $ExpectType number \ No newline at end of file +test.updateRating(test.getExpected(1200, 1500), 1300, 1500); // $ExpectType number diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index d3265cb15b..b702e6bd9a 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -5,10 +5,8 @@ export default class EloRank { constructor(kFactor?: number); - setKFactor(kFactor: number): void; getKFactor(): number; getExpected(a: number, b: number): number; - updateRating(expected: number, actual: number, current: number): number; } From 19e524a21c3f8d6cf2ef097b429146e0299d1db7 Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Thu, 7 Feb 2019 14:53:54 +0100 Subject: [PATCH 05/11] Fixes export default --- types/elo-rank/elo-rank-tests.ts | 2 +- types/elo-rank/index.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/types/elo-rank/elo-rank-tests.ts b/types/elo-rank/elo-rank-tests.ts index 2d3c40ad14..2e53764042 100644 --- a/types/elo-rank/elo-rank-tests.ts +++ b/types/elo-rank/elo-rank-tests.ts @@ -1,4 +1,4 @@ -import EloRank from 'elo-rank'; +import { EloRank } from "elo-rank"; const test = new EloRank(); diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index b702e6bd9a..c9e6178750 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -3,7 +3,7 @@ // Definitions by: Antonio Pavlinovic // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -export default class EloRank { +export class EloRank { constructor(kFactor?: number); setKFactor(kFactor: number): void; getKFactor(): number; From cc7c708a5b30715c562af232cb5d4096e5e40aec Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 11 Feb 2019 11:14:09 +0100 Subject: [PATCH 06/11] Export changes --- types/elo-rank/index.d.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index c9e6178750..2a1f63c7ff 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -3,10 +3,12 @@ // Definitions by: Antonio Pavlinovic // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -export class EloRank { +declare class EloRank { constructor(kFactor?: number); setKFactor(kFactor: number): void; getKFactor(): number; getExpected(a: number, b: number): number; updateRating(expected: number, actual: number, current: number): number; } + +export = EloRank; \ No newline at end of file From c748258bfb7000ad864d6d8cb01a30710471938a Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 11 Feb 2019 11:44:28 +0100 Subject: [PATCH 07/11] Fixing build --- types/elo-rank/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index 2a1f63c7ff..df0cd09c9e 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -11,4 +11,4 @@ declare class EloRank { updateRating(expected: number, actual: number, current: number): number; } -export = EloRank; \ No newline at end of file +export = EloRank; From 353f6026f11ca58ff2629b8e57d5d2513a3bb654 Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 11 Feb 2019 12:21:36 +0100 Subject: [PATCH 08/11] Testing CI --- types/elo-rank/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index df0cd09c9e..541d070394 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -3,7 +3,7 @@ // Definitions by: Antonio Pavlinovic // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -declare class EloRank { +class EloRank { constructor(kFactor?: number); setKFactor(kFactor: number): void; getKFactor(): number; From aefa57eaf893873aef0b36b9ec7dbac2a436ed36 Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 11 Feb 2019 12:25:54 +0100 Subject: [PATCH 09/11] Changes needed for exports --- types/elo-rank/elo-rank-tests.ts | 2 +- types/elo-rank/index.d.ts | 2 +- types/elo-rank/tsconfig.json | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/types/elo-rank/elo-rank-tests.ts b/types/elo-rank/elo-rank-tests.ts index 2e53764042..4032d46f0a 100644 --- a/types/elo-rank/elo-rank-tests.ts +++ b/types/elo-rank/elo-rank-tests.ts @@ -1,4 +1,4 @@ -import { EloRank } from "elo-rank"; +import EloRank from "elo-rank"; const test = new EloRank(); diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index 541d070394..df0cd09c9e 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -3,7 +3,7 @@ // Definitions by: Antonio Pavlinovic // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -class EloRank { +declare class EloRank { constructor(kFactor?: number); setKFactor(kFactor: number): void; getKFactor(): number; diff --git a/types/elo-rank/tsconfig.json b/types/elo-rank/tsconfig.json index 2ebd08f352..21cf1d2f88 100644 --- a/types/elo-rank/tsconfig.json +++ b/types/elo-rank/tsconfig.json @@ -14,7 +14,8 @@ ], "types": [], "noEmit": true, - "forceConsistentCasingInFileNames": true + "forceConsistentCasingInFileNames": true, + "esModuleInterop": true }, "files": [ "index.d.ts", From 624cbdaa3e2476934ada28aadf26aec29d813ecc Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Mon, 11 Feb 2019 14:35:42 +0100 Subject: [PATCH 10/11] Typescript 2.7 --- types/elo-rank/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index df0cd09c9e..25f046cbd3 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -2,8 +2,9 @@ // Project: https://github.com/dmamills/elo-rank#readme // Definitions by: Antonio Pavlinovic // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 2.7 -declare class EloRank { +class EloRank { constructor(kFactor?: number); setKFactor(kFactor: number): void; getKFactor(): number; From d35f65ac1410e3effb48be44de8615c5da53484b Mon Sep 17 00:00:00 2001 From: Antonio Pavlinovic Date: Tue, 12 Feb 2019 11:36:04 +0100 Subject: [PATCH 11/11] Typescript madness --- types/elo-rank/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/elo-rank/index.d.ts b/types/elo-rank/index.d.ts index 25f046cbd3..489be40fdc 100644 --- a/types/elo-rank/index.d.ts +++ b/types/elo-rank/index.d.ts @@ -4,7 +4,7 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.7 -class EloRank { +declare class EloRank { constructor(kFactor?: number); setKFactor(kFactor: number): void; getKFactor(): number;