From a6f478678ab3aab017b69b1bc7bc6964d16751a5 Mon Sep 17 00:00:00 2001 From: Andy Date: Mon, 17 Apr 2017 09:18:27 -0700 Subject: [PATCH] knockout-paging: Provides its own types (#15636) --- notNeededPackages.json | 6 ++ types/knockout-paging/index.d.ts | 67 -------------- .../knockout-paging/knockout-paging-tests.ts | 90 ------------------- types/knockout-paging/tsconfig.json | 23 ----- 4 files changed, 6 insertions(+), 180 deletions(-) delete mode 100644 types/knockout-paging/index.d.ts delete mode 100644 types/knockout-paging/knockout-paging-tests.ts delete mode 100644 types/knockout-paging/tsconfig.json diff --git a/notNeededPackages.json b/notNeededPackages.json index fb75bb1b4d..7872ce4b0f 100644 --- a/notNeededPackages.json +++ b/notNeededPackages.json @@ -204,6 +204,12 @@ "sourceRepoURL": "https://github.com/tdegrunt/jsonschema", "asOfVersion": "1.1.1" }, + { + "libraryName": "knockout-paging", + "typingsPackageName": "knockout-paging", + "sourceRepoURL": "https://github.com/ErikSchierboom/knockout-paging", + "asOfVersion": "0.3.1" + }, { "libraryName": "Linq.JS", "typingsPackageName": "linq", diff --git a/types/knockout-paging/index.d.ts b/types/knockout-paging/index.d.ts deleted file mode 100644 index 5c1491039b..0000000000 --- a/types/knockout-paging/index.d.ts +++ /dev/null @@ -1,67 +0,0 @@ -// Type definitions for knockout-paging -// Project: https://github.com/ErikSchierboom/knockout-paging -// Definitions by: Erik Schierboom -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - -/// - -interface KnockoutStatic { - paging: KnockoutPagingOptions; - pagedObservableArray(initialValue?: T[], options?: KnockoutPagedOptions): KnockoutPagedObservableArray; -} - -interface KnockoutPagingOptions { - defaults: KnockoutPagingDefaultOptions; - generators: { - [name: string]: KnockoutPageGenerator; - 'sliding': KnockoutSlidingPageGenerator - } -} - -interface KnockoutPagingDefaultOptions { - pageNumber: number; - pageSize: number; -} - -interface KnockoutPagedObservableArray extends KnockoutObservableArray { - pageSize: KnockoutObservable; - pageNumber: KnockoutObservable; - - pageItems: KnockoutComputed; - pageCount: KnockoutComputed; - itemCount: KnockoutComputed; - firstItemOnPage: KnockoutComputed; - lastItemOnPage: KnockoutComputed; - hasPreviousPage: KnockoutComputed; - hasNextPage: KnockoutComputed; - isFirstPage: KnockoutComputed; - isLastPage: KnockoutComputed; - pages: KnockoutComputed; - - toNextPage(): void; - toPreviousPage(): void; - toLastPage(): void; - toFirstPage(): void; -} - -interface KnockoutPagedOptions { - pageSize?: number; - pageNumber?: number; - pageGenerator?: string; -} - -interface KnockoutObservableArray { - extend(requestedExtenders: { 'paged': any; }): KnockoutPagedObservableArray; -} - -interface KnockoutPageGenerator { - generate(pagedObservable: KnockoutPagedObservableArray): number[]; -} - -interface KnockoutSlidingPageGenerator extends KnockoutPageGenerator { - windowSize: KnockoutObservable; -} - -interface KnockoutExtenders { - paged(target: KnockoutObservableArray, options: KnockoutPagedOptions): KnockoutObservableArray; -} \ No newline at end of file diff --git a/types/knockout-paging/knockout-paging-tests.ts b/types/knockout-paging/knockout-paging-tests.ts deleted file mode 100644 index ddf015613b..0000000000 --- a/types/knockout-paging/knockout-paging-tests.ts +++ /dev/null @@ -1,90 +0,0 @@ - - -// Different option formats -var emptyOptions = {}; -var pageNumberOptions = { pageNumber: 2 }; -var pageSizeOptions = { pageSize: 10 }; -var generatorOptions = { pageGenerator: 'sliding' }; -var allOptions = { pageNumber: 2, pageSize: 10, pageGenerator: 'sliding' }; - -function defaults() { - ko.paging.defaults.pageNumber = 1; - ko.paging.defaults.pageSize = 50; -} - -function pageGenerators() { - - // Allow to set the windowSize on sliding page generator - ko.paging.generators['sliding'].windowSize(5); - - // Add custom page generator - ko.paging.generators['custom'] = { - generate: function(pagedObservable: KnockoutObservable) { - return [0, 1]; - } - } -} - -function usingPagedObservableArrayFunctionOnKnockoutStatic() { - var simplePaged = ko.pagedObservableArray(); - var initializedPaged = ko.pagedObservableArray([1, 2, 3]); - var emptyOptionsPaged = ko.pagedObservableArray([1, 2, 3], emptyOptions); - var pageNumberOptionsPaged = ko.pagedObservableArray([1, 2, 3], pageNumberOptions); - var pageSizeOptionsPaged = ko.pagedObservableArray([1, 2, 3], pageSizeOptions); - var generatorOptionsPaged = ko.pagedObservableArray([1, 2, 3], generatorOptions); - var allOptionsPaged = ko.pagedObservableArray([1, 2, 3], allOptions); - - // Here we verify that the returned type is the paged observable array - simplePaged.pageSize(); - initializedPaged.pageSize(); - emptyOptionsPaged.pageSize(); - pageNumberOptionsPaged.pageSize(); - pageSizeOptionsPaged.pageSize(); - generatorOptionsPaged.pageSize(); - allOptionsPaged.pageSize(); -} - -function usingExtend() { - var emptyOptionsPaged = ko.observableArray([]).extend({ paged: emptyOptions }); - var pageNumberOptionsPaged = ko.observableArray([]).extend({ paged: pageNumberOptions }); - var pageSizeOptionsPaged = ko.observableArray([]).extend({ paged: pageSizeOptions }); - var generatorOptionsPaged = ko.observableArray([]).extend({ paged: generatorOptions }); - var allOptionsPaged = ko.observableArray([]).extend({ paged: allOptions }); - var withInitialArrayValue = ko.observableArray([1, 2, 3]).extend({ paged: emptyOptions }); - - // Here we verify that the returned type is the paged observable array - emptyOptionsPaged.pageSize(); - pageNumberOptionsPaged.pageSize(); - pageSizeOptionsPaged.pageSize(); - generatorOptionsPaged.pageSize(); - allOptionsPaged.pageSize(); -} - -function observables() { - var paged = ko.pagedObservableArray([]); - var pageSize = paged.pageSize(); - var pageNumber = paged.pageNumber(); -} - -function computed() { - var paged = ko.pagedObservableArray([]); - var pageItems = paged.pageItems(); - var pageCount = paged.pageCount(); - var itemCount = paged.itemCount(); - var firstItemOnPage = paged.firstItemOnPage(); - var lastItemOnPage = paged.lastItemOnPage(); - var hasPreviousPage = paged.hasPreviousPage(); - var hasNextPage = paged.hasNextPage(); - var isFirstPage = paged.isFirstPage(); - var isLastPage = paged.isLastPage(); - var pages = paged.pages(); -} - -function functions() { - var paged = ko.pagedObservableArray([]); - paged.toNextPage(); - paged.toLastPage(); - paged.toNextPage(); - paged.toPreviousPage(); - paged.toFirstPage(); -} \ No newline at end of file diff --git a/types/knockout-paging/tsconfig.json b/types/knockout-paging/tsconfig.json deleted file mode 100644 index bbf9623f3e..0000000000 --- a/types/knockout-paging/tsconfig.json +++ /dev/null @@ -1,23 +0,0 @@ -{ - "compilerOptions": { - "module": "commonjs", - "lib": [ - "es6", - "dom" - ], - "noImplicitAny": true, - "noImplicitThis": true, - "strictNullChecks": false, - "baseUrl": "../", - "typeRoots": [ - "../" - ], - "types": [], - "noEmit": true, - "forceConsistentCasingInFileNames": true - }, - "files": [ - "index.d.ts", - "knockout-paging-tests.ts" - ] -} \ No newline at end of file