vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2025-10-16 12:05:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

d3-selection: Disable tslint error on TS 3.9 (#43269)

Browse Source 
DOM updates in 3.9 mean that Typescript now knows that
`HTMLBodyElement.ownerDocument` can't actually be null. Previously, a
non-null assertion was needed.

Because the tests have to compile on 3.9 AND older versions, I just
disabled the rule.
This commit is contained in:
Nathan Shively-Sanders 2020-03-20 11:53:58 -07:00 committed by GitHub
parent 551f768a3f
commit a94ee28b62
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
types/d3-selection/d3-selection-tests.ts
View File

@ -836,16 +836,19 @@ newDiv = body.append(function(d, i, g) {
const index: number = i;
const group: HTMLBodyElement[] | d3Selection.ArrayLike<HTMLBodyElement> = g;
console.log('Body element foo property: ', d.foo); // data of type BodyDatum
// tslint:disable-next-line:no-unnecessary-type-assertion
return this.ownerDocument!.createElement('div'); // this-type HTMLBodyElement
});
// $ExpectError
newDiv = body.append<HTMLDivElement>(function(d) {
// tslint:disable-next-line:no-unnecessary-type-assertion
return this.ownerDocument!.createElement('a'); // fails, HTMLDivElement expected by type parameter, HTMLAnchorElement returned
});
// $ExpectError
newDiv = body.append(function(d) {
// tslint:disable-next-line:no-unnecessary-type-assertion
return this.ownerDocument!.createElement('a'); // fails, HTMLDivElement expected by inference, HTMLAnchorElement returned
});
@ -870,6 +873,7 @@ const typeValueFunction = function(
i: number,
g: HTMLBodyElement[] | d3Selection.ArrayLike<HTMLBodyElement>
) {
// tslint:disable-next-line:no-unnecessary-type-assertion
return this.ownerDocument!.createElement('p'); // this-type HTMLParagraphElement
};