diff --git a/types/express-session/express-session-tests.ts b/types/express-session/express-session-tests.ts index 24a2e8bab0..925d7d12c2 100644 --- a/types/express-session/express-session-tests.ts +++ b/types/express-session/express-session-tests.ts @@ -7,6 +7,22 @@ app.use(session({ secret: 'keyboard cat', cookie: { secure: true } })); +app.use(session({ + secret: 'keyboard cat', + cookie: { secure: 'auto' } +})); +app.use(session({ + secret: 'keyboard cat', + cookie: { sameSite: 'none' } +})); +app.use(session({ + secret: 'keyboard cat', + cookie: { sameSite: 'lax' } +})); +app.use(session({ + secret: 'keyboard cat', + cookie: { sameSite: 'strict' } +})); app.use(session({ secret: 'keyboard cat', name: 'connect.sid', diff --git a/types/express-session/index.d.ts b/types/express-session/index.d.ts index dc5f5601df..9dd2ef206e 100644 --- a/types/express-session/index.d.ts +++ b/types/express-session/index.d.ts @@ -4,6 +4,7 @@ // Jacob Bogers // Naoto Yokoyama // Ryan Cannon +// Tom Spencer // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -58,7 +59,17 @@ declare namespace session { secret: string | string[]; name?: string; store?: Store | MemoryStore; - cookie?: express.CookieOptions; + cookie?: { + maxAge?: number; + signed?: boolean; + expires?: Date; + httpOnly?: boolean; + path?: string; + domain?: string; + secure?: boolean | 'auto'; + encode?: (val: string) => string; + sameSite?: boolean | 'lax' | 'strict' | 'none'; + }; genid?(req: express.Request): string; rolling?: boolean; resave?: boolean;