vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2025-10-16 12:05:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[webpack]: Fixed type of beforeRun hook. (#32208)

Browse Source 
* [webpack]: Fixed type of beforeRun hook.

Previously this took a `Compilation` parameter, but actually takes a `Compiler`. See ccc7db79ba/lib/Compiler.js (L50-L51)

* Changed run hook from taking `Compilation` parameter to taking `Compiler` parameter.
This commit is contained in:
Cameron Martin 2019-01-16 13:53:34 +00:00 committed by John Reilly
parent 5f012ded23
commit abb32ebad4
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
types/webpack/index.d.ts vendored
View File

@ -988,8 +988,8 @@ declare namespace webpack {
shouldEmit: SyncBailHook<Compilation>;
done: AsyncSeriesHook<Stats>;
additionalPass: AsyncSeriesHook;
beforeRun: AsyncSeriesHook<Compilation>;
run: AsyncSeriesHook<Compilation>;
beforeRun: AsyncSeriesHook<Compiler>;
run: AsyncSeriesHook<Compiler>;
emit: AsyncSeriesHook<Compilation>;
afterEmit: AsyncSeriesHook<Compilation>;
thisCompilation: SyncHook<Compilation, { normalModuleFactory: NormalModuleFactory }>;

3
types/webpack/webpack-tests.ts
View File

@ -284,6 +284,9 @@ configuration = {
callback
);
});
this.hooks.beforeRun.tap("SomePlugin", (compiler: webpack.Compiler) => {});
this.hooks.run.tap("SomePlugin", (compiler: webpack.Compiler) => {});
}
]
};