From b5d5e7bf9384a814d16b32c3b0fd3ca9c292e0e3 Mon Sep 17 00:00:00 2001 From: Wink Saville Date: Wed, 5 Apr 2017 13:32:07 -0700 Subject: [PATCH 1/2] Update README.md --- README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 6868d116cf..5698530638 100644 --- a/README.md +++ b/README.md @@ -71,7 +71,9 @@ Add to your `tsconfig.json`: Create `types/foo/index.d.ts` containing declarations for the module "foo". You should now be able import from `"foo"` in your code and it will route to the new type definition. Then build *and* run the code to make sure your type definition actually corresponds to what happens at runtime. -Once you've tested your definitions with real code, make a PR contributing the definition by copying `types/foo` to `DefinitelyTyped/foo` and adding a `tsconfig.json` and `foo-tests.ts`. +Once you've tested your definitions with real code, make a [PR](#make-a-pull-request) +then follow the instructions for [Edit an existing package](#edit-an-existing-package) or +[Create a new package](#create-a-new-package). ### Make a pull request @@ -83,7 +85,7 @@ First, [fork](https://guides.github.com/activities/forking/) this repository, in #### Edit an existing package -* `cd my-package-to-edit` +* `cd types/my-package-to-edit` * Make changes. Remember to edit tests. * You may also want to add yourself to "Definitions by" section of the package header. - Do this by adding your name to the end of the line, as in `// Definitions by: Alice , Bob `. From 8c6be6ea2da19e5414a47920396ece3ea5678e33 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Mon, 17 Apr 2017 09:49:48 -0700 Subject: [PATCH 2/2] for edit -> to edit, and uncapitalize "edit" --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 50b0628543..28a4b19e3e 100644 --- a/README.md +++ b/README.md @@ -72,8 +72,8 @@ Create `types/foo/index.d.ts` containing declarations for the module "foo". You should now be able import from `"foo"` in your code and it will route to the new type definition. Then build *and* run the code to make sure your type definition actually corresponds to what happens at runtime. Once you've tested your definitions with real code, make a [PR](#make-a-pull-request) -then follow the instructions for [Edit an existing package](#edit-an-existing-package) or -[Create a new package](#create-a-new-package). +then follow the instructions to [edit an existing package](#edit-an-existing-package) or +[create a new package](#create-a-new-package). ### Make a pull request