From ad644bc4f3ac1d2fa0e825b211a16d46a77589b5 Mon Sep 17 00:00:00 2001
From: Troy Weber <troywweber@gmail.com>
Date: Mon, 20 Mar 2017 15:31:39 -0700
Subject: [PATCH] more PR fixes

---
 firmata/firmata-tests.ts |  4 ----
 firmata/index.d.ts       | 18 +++++++++---------
 firmata/tsconfig.json    |  2 +-
 firmata/tslint.json      |  1 +
 4 files changed, 11 insertions(+), 14 deletions(-)
 create mode 100644 firmata/tslint.json

diff --git a/firmata/firmata-tests.ts b/firmata/firmata-tests.ts
index 93cbb7d8db..c37b1417eb 100644
--- a/firmata/firmata-tests.ts
+++ b/firmata/firmata-tests.ts
@@ -1,7 +1,3 @@
-// Tests for firmata.d.ts
-// Project: https://github.com/firmata/firmata.js
-// Definitions by:  Troy W. <https://github.com/troywweber7, https://bitbucket.org/troywweber/>
-
 import * as Board from 'firmata'
 
 function test_basic_board()
diff --git a/firmata/index.d.ts b/firmata/index.d.ts
index 842a8fa57c..a79209ef68 100644
--- a/firmata/index.d.ts
+++ b/firmata/index.d.ts
@@ -11,7 +11,7 @@ declare module 'firmata'
 	export = Board;
 
 	/**
-	 * Most of these are generated by observing https://github.com/firmata/firmata.js/blob/master/lib/firmata.js.
+	 * Most of these are generated by observing https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js.
 	 *
 	 * This is a starting point that appeared to work fine for months within a project of my company, but I give no
 	 * guarantee that it cannot be improved.
@@ -209,7 +209,7 @@ declare module 'firmata'
 		}
 
 		// TODO these enums could actually be non-const in the future (provides some benefits) --- TWW
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L431
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L449-L464
 		export const enum PIN_MODES {
 			INPUT = 0x00,
 			OUTPUT = 0x01,
@@ -242,14 +242,14 @@ declare module 'firmata'
 			DISABLED = 0,
 		}
 
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L456
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L474-L478
 		export const enum STEPPER_TYPES {
 			DRIVER = 1,
 			TWO_WIRE = 2,
 			FOUR_WIRE = 4,
 		}
 
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L461
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L479-L484
 		export const enum STEPPER_RUN_STATES {
 			STOP = 0,
 			ACCEL = 1,
@@ -257,13 +257,13 @@ declare module 'firmata'
 			RUN = 3,
 		}
 
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L467
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L485-L488
 		export const enum STEPPER_DIRECTIONS {
 			CCW = 0,
 			CW = 1,
 		}
 
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L448
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L466-L471
 		export const enum I2C_MODES {
 			WRITE = 0,
 			READ = 1,
@@ -271,13 +271,13 @@ declare module 'firmata'
 			STOP_READING = 3
 		}
 
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L473
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L491-L494
 		export const enum SERIAL_MODES {
 			CONTINUOUS_READ = 0x00,
 			STOP_READING = 0x01,
 		}
 
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L479
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L497-L512
 		export const enum SERIAL_PORT_IDs {
 			HW_SERIAL0 = 0x00,
 			HW_SERIAL1 = 0x01,
@@ -290,7 +290,7 @@ declare module 'firmata'
 			DEFAULT = 0x08,
 		}
 
-		// https://github.com/firmata/firmata.js/blob/master/lib/firmata.js#L497
+		// https://github.com/firmata/firmata.js/blob/v0.15.0/lib/firmata.js#L515-L524
 		export const enum SERIAL_PIN_TYPES {
 			RES_RX0 = 0x00,
 			RES_TX0 = 0x01,
diff --git a/firmata/tsconfig.json b/firmata/tsconfig.json
index e3a8151369..3b0d4b97cb 100644
--- a/firmata/tsconfig.json
+++ b/firmata/tsconfig.json
@@ -6,7 +6,7 @@
     ],
     "noImplicitAny": true,
     "noImplicitThis": true,
-    "strictNullChecks": false,
+    "strictNullChecks": true,
     "baseUrl": "../",
     "typeRoots": [
       "../"
diff --git a/firmata/tslint.json b/firmata/tslint.json
new file mode 100644
index 0000000000..2221e40e4a
--- /dev/null
+++ b/firmata/tslint.json
@@ -0,0 +1 @@
+{ "extends": "../tslint.json" }
\ No newline at end of file