From cf2be352fa04728a7607ecc5447a64978935aaea Mon Sep 17 00:00:00 2001 From: yuyaryshev Date: Fri, 8 Feb 2019 13:49:47 +0300 Subject: [PATCH 1/2] Update index.d.ts Here https://node-postgres.com/guides/upgrading#client-query-submittable- and here https://node-postgres.com/api/client#-code-client-query-config-queryconfig-gt-promise-lt-result-gt-code- event emmiter functionality is described . But in typescript it's not supported: ``` export class Query extends events.EventEmitter { // <<<<<<<<< Does not extends Submittable on(event: "row", listener: (row: any, result?: ResultBuilder) => void): this; on(event: "error", listener: (err: Error) => void): this; on(event: "end", listener: (result: ResultBuilder) => void): this; } ``` So here is a pool request to fix this. --- types/pg/index.d.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/types/pg/index.d.ts b/types/pg/index.d.ts index 44863aee0b..aa95c4f79c 100644 --- a/types/pg/index.d.ts +++ b/types/pg/index.d.ts @@ -206,7 +206,10 @@ export interface PoolClient extends ClientBase { release(err?: Error): void; } -export class Query extends events.EventEmitter { +export class Query extends events.EventEmitter implements Submittable { + constructor(); + constructor(queryTextOrConfig: string | QueryConfig, values?: any[]); + submit: (connection: Connection) => void; on(event: "row", listener: (row: any, result?: ResultBuilder) => void): this; on(event: "error", listener: (err: Error) => void): this; on(event: "end", listener: (result: ResultBuilder) => void): this; From 4a4ea0c3e73c2b0aa5a74282c5eeb192c3dbed42 Mon Sep 17 00:00:00 2001 From: yuyaryshev Date: Fri, 8 Feb 2019 14:38:27 +0300 Subject: [PATCH 2/2] Fixed Travic complains abount constructor --- types/pg/index.d.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/types/pg/index.d.ts b/types/pg/index.d.ts index aa95c4f79c..3caa3e2e7f 100644 --- a/types/pg/index.d.ts +++ b/types/pg/index.d.ts @@ -207,8 +207,7 @@ export interface PoolClient extends ClientBase { } export class Query extends events.EventEmitter implements Submittable { - constructor(); - constructor(queryTextOrConfig: string | QueryConfig, values?: any[]); + constructor(queryTextOrConfig?: string | QueryConfig, values?: any[]); submit: (connection: Connection) => void; on(event: "row", listener: (row: any, result?: ResultBuilder) => void): this; on(event: "error", listener: (err: Error) => void): this;