From 75723b04732245f84130f6de84c3490ee8c74403 Mon Sep 17 00:00:00 2001
From: Chet Husk <chusk3@gmail.com>
Date: Tue, 28 Nov 2017 15:29:33 -0600
Subject: [PATCH] allow for undefined transactions

---
 types/knex/index.d.ts    | 2 +-
 types/knex/knex-tests.ts | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/types/knex/index.d.ts b/types/knex/index.d.ts
index aaee0b27f7..e96dfbefd8 100644
--- a/types/knex/index.d.ts
+++ b/types/knex/index.d.ts
@@ -156,7 +156,7 @@ declare namespace Knex {
         delete(returning?: string | string[]): QueryBuilder;
         truncate(): QueryBuilder;
 
-        transacting(trx: Transaction): QueryBuilder;
+        transacting(trx?: Transaction): QueryBuilder;
         connection(connection: any): QueryBuilder;
 
         clone(): QueryBuilder;
diff --git a/types/knex/knex-tests.ts b/types/knex/knex-tests.ts
index dec1bf055f..c7c99813f1 100644
--- a/types/knex/knex-tests.ts
+++ b/types/knex/knex-tests.ts
@@ -672,6 +672,9 @@ knex.transaction<{ length: number }>(function(trx) {
   console.error(error);
 });
 
+// transacting handles undefined
+knex.insert({ name: 'Old Books'}).transacting(undefined);
+
 knex.schema.withSchema("public").hasTable("table") as Promise<boolean>;
 
 knex.schema.createTable('users', function (table) {