From adf8a1b87a1fa16b0a43b4489acc4e669db74dc5 Mon Sep 17 00:00:00 2001 From: Julian Waller Date: Fri, 14 Feb 2020 02:47:42 +0100 Subject: [PATCH] [node-hid]: add writes with Buffers for 1.2.0 (#42338) --- types/node-hid/index.d.ts | 6 +++--- types/node-hid/node-hid-tests.ts | 16 ++++++++++------ 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/types/node-hid/index.d.ts b/types/node-hid/index.d.ts index 7c510d5463..73c25be046 100644 --- a/types/node-hid/index.d.ts +++ b/types/node-hid/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for node-hid 0.7 +// Type definitions for node-hid 1.2 // Project: https://github.com/node-hid/node-hid#readme // Definitions by: Mohamed Hegazy // Robert Kiss @@ -30,10 +30,10 @@ export class HID extends EventEmitter { read(callback: (err: any, data: number[]) => void): void; readSync(): number[]; readTimeout(time_out: number): number[]; - sendFeatureReport(data: number[]): number; + sendFeatureReport(data: number[] | Buffer): number; getFeatureReport(report_id: number, report_length: number): number[]; resume(): void; - write(values: number[]): number; + write(values: number[] | Buffer): number; setNonBlocking(no_block: boolean): void; } export function devices(): Device[]; diff --git a/types/node-hid/node-hid-tests.ts b/types/node-hid/node-hid-tests.ts index 543f313681..2c2c1ace65 100644 --- a/types/node-hid/node-hid-tests.ts +++ b/types/node-hid/node-hid-tests.ts @@ -2,20 +2,24 @@ import HID = require('node-hid'); const devices = HID.devices(); -let device = new HID.HID("path"); +let device = new HID.HID('path'); device = new HID.HID(12, 22); device.setNonBlocking(true); -device.on("data", data => {}); -device.once("data", data => {}); -device.on("error", err => {}); +device.on('data', data => {}); +device.once('data', data => {}); +device.on('error', err => {}); device.write([0x00, 0x01, 0x01, 0x05, 0xff, 0xff]); +device.write(Buffer.from([0x00, 0x01, 0x01, 0x05, 0xff, 0xff])); + +device.sendFeatureReport([0x00, 0x01, 0x01, 0x05, 0xff, 0xff]); +device.sendFeatureReport(Buffer.from([0x00, 0x01, 0x01, 0x05, 0xff, 0xff])); device.pause(); device.resume(); -device.removeListener("data", data => {}); -device.removeAllListeners("data"); +device.removeListener('data', data => {}); +device.removeAllListeners('data'); device.close();