From ae3fbb870e14a67ac7e04c95941cd2e9e8717fed Mon Sep 17 00:00:00 2001 From: Dmitri1337 Date: Wed, 16 Jan 2019 19:23:45 +0200 Subject: [PATCH] Fixed "no-var-keyword" lint rule --- types/async/test/explicit.ts | 4 ++-- types/async/test/index.ts | 3 ++- types/async/tslint.json | 1 - 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/types/async/test/explicit.ts b/types/async/test/explicit.ts index 8f910e4b37..5c2e5e46e6 100644 --- a/types/async/test/explicit.ts +++ b/types/async/test/explicit.ts @@ -1,7 +1,7 @@ interface StringCallback { (err?: Error, result?: string): void; } interface AsyncStringGetter { (callback: StringCallback): void; } -var taskArray: AsyncStringGetter[] = [ +const taskArray: AsyncStringGetter[] = [ function(callback) { setTimeout(function() { callback(undefined, 'one'); @@ -43,7 +43,7 @@ interface Lookup { [key: string]: T; } interface NumberCallback { (err?: Error, result?: number): void; } interface AsyncNumberGetter { (callback: NumberCallback): void; } -var taskDict: Lookup = { +const taskDict: Lookup = { one: function(callback) { setTimeout(function() { callback(undefined, 1); diff --git a/types/async/test/index.ts b/types/async/test/index.ts index 9a7e033e2a..8b764d0c10 100644 --- a/types/async/test/index.ts +++ b/types/async/test/index.ts @@ -242,7 +242,8 @@ function whileFn(callback: any) { function whileTest() { return count < 5; } function doWhileTest(count: number) { return count < 5; } -var count = 0; + +let count = 0; async.whilst(whileTest, whileFn, function(err) { }); async.until(whileTest, whileFn, function(err) { }); async.doWhilst(whileFn, doWhileTest, function(err) { }); diff --git a/types/async/tslint.json b/types/async/tslint.json index 825ad443c1..e898fbac8d 100644 --- a/types/async/tslint.json +++ b/types/async/tslint.json @@ -5,7 +5,6 @@ "callable-types": false, // HAS ISSUES "comment-format": true, // PRODUCES ERRORS WHEN REMOVED "no-unnecessary-generics": false, // HAS ISSUES - "no-var-keyword": false, // HAS ISSUES "no-void-expression": false, // HAS ISSUES "object-literal-key-quotes": false, // HAS ISSUES "object-literal-shorthand": false, // HAS ISSUES