From 0d20a346cf9605b84c521d86cd395c8901857dc4 Mon Sep 17 00:00:00 2001 From: Andrew Kittredge Date: Fri, 21 Dec 2018 12:09:21 -0500 Subject: [PATCH] [ui-grid] Fix signature of getVisibleRows I don't think getVisibleRows takes any arguments. The definition of getVisibleRows from line 1800 of https://github.com/angular-ui/ui-grid/blob/47c12394b0e8adf56a78e4e8b6a6f496554f910b/packages/core/src/js/factories/Grid.js is- Grid.prototype.getVisibleRows = function getVisibleRows() { return this.renderContainers.body.visibleRowCache; }; --- types/ui-grid/index.d.ts | 3 +-- types/ui-grid/ui-grid-tests.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/types/ui-grid/index.d.ts b/types/ui-grid/index.d.ts index 9334e91669..8056b4cc07 100644 --- a/types/ui-grid/index.d.ts +++ b/types/ui-grid/index.d.ts @@ -927,10 +927,9 @@ declare namespace uiGrid { clearRowInvisible(rowEntity: TEntity): void; /** * Returns all visible rows - * @param {IGridInstance} grid the grid you want to get visible rows from * @returns {Array} an array of gridRow */ - getVisibleRows(grid: IGridInstanceOf): Array>; + getVisibleRows(): Array>; /** * Trigger a grid resize, normally this would be picked * up by a watch on window size, but in some circumstances it is necessary diff --git a/types/ui-grid/ui-grid-tests.ts b/types/ui-grid/ui-grid-tests.ts index 1e424985fb..027619b3d4 100644 --- a/types/ui-grid/ui-grid-tests.ts +++ b/types/ui-grid/ui-grid-tests.ts @@ -117,7 +117,7 @@ var uiGridConstants: uiGrid.IUiGridConstants; gridApi.core.clearAllFilters(true); gridApi.core.addToGridMenu(gridInstance, [menuItem]); -gridApi.core.getVisibleRows(gridInstance); +gridApi.core.getVisibleRows(); gridApi.core.handleWindowResize(); gridApi.core.queueGridRefresh(); gridApi.core.queueRefresh();