From 45006ffe13c4be86f26b458fdd5f240b909e2ae5 Mon Sep 17 00:00:00 2001 From: Alex Young Date: Thu, 29 Jun 2017 10:52:48 +0100 Subject: [PATCH] Change secretOrKey to union type of string or Buffer, and add relevant test. --- types/passport-jwt/index.d.ts | 3 ++- types/passport-jwt/passport-jwt-tests.ts | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/types/passport-jwt/index.d.ts b/types/passport-jwt/index.d.ts index bbf96be851..066921efe6 100644 --- a/types/passport-jwt/index.d.ts +++ b/types/passport-jwt/index.d.ts @@ -1,6 +1,7 @@ // Type definitions for passport-jwt 2.0 // Project: https://github.com/themikenicholson/passport-jwt // Definitions by: TANAKA Koichi +// Alex Young // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped import {Strategy as PassportStrategy} from 'passport-strategy'; @@ -12,7 +13,7 @@ export declare class Strategy extends PassportStrategy { } export interface StrategyOptions { - secretOrKey: string; + secretOrKey: string | Buffer; jwtFromRequest: JwtFromRequestFunction; issuer?: string; audience?: string; diff --git a/types/passport-jwt/passport-jwt-tests.ts b/types/passport-jwt/passport-jwt-tests.ts index 07b8deb1f4..1dd2baeb1e 100644 --- a/types/passport-jwt/passport-jwt-tests.ts +++ b/types/passport-jwt/passport-jwt-tests.ts @@ -33,5 +33,6 @@ opts.jwtFromRequest = ExtractJwt.fromUrlQueryParameter('param_name'); opts.jwtFromRequest = ExtractJwt.fromAuthHeaderWithScheme('param_name'); opts.jwtFromRequest = ExtractJwt.fromExtractors([ExtractJwt.fromHeader('x-api-key'), ExtractJwt.fromBodyField('field_name'), ExtractJwt.fromUrlQueryParameter('param_name')]); opts.jwtFromRequest = (req: Request) => { return req.query.token; }; +opts.secretOrKey = new Buffer('secret'); declare function findUser(condition: {id: string}, callback: (error: any, user :any) => void): void;