From 5c103e4bd59d93421c49d2861e7d47c43ecc5b55 Mon Sep 17 00:00:00 2001 From: Waseem Dahman Date: Tue, 16 Oct 2018 15:55:00 -0400 Subject: [PATCH 1/3] [jest-axe] update tsconfig --- types/jest-axe/tsconfig.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/jest-axe/tsconfig.json b/types/jest-axe/tsconfig.json index 887813c869..1889f0045d 100644 --- a/types/jest-axe/tsconfig.json +++ b/types/jest-axe/tsconfig.json @@ -2,7 +2,8 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es6" + "es6", + "dom" ], "noImplicitAny": true, "noImplicitThis": true, From 1251a33064131fd31b832d7584bb9fe0128e1a5d Mon Sep 17 00:00:00 2001 From: Waseem Dahman Date: Tue, 23 Oct 2018 21:30:43 -0400 Subject: [PATCH 2/3] augment axe-core Node's type --- types/jest-axe/index.d.ts | 4 ++++ types/jest-axe/tsconfig.json | 3 +-- types/jest-axe/tslint.json | 7 ++++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/types/jest-axe/index.d.ts b/types/jest-axe/index.d.ts index f16f4e7651..7398572bb1 100644 --- a/types/jest-axe/index.d.ts +++ b/types/jest-axe/index.d.ts @@ -8,6 +8,10 @@ import { AxeResults, Result, RunOnly } from "axe-core"; +declare module "axe-core" { + interface Node {} +} + /** * Version of the aXe verifier with defaults set. * diff --git a/types/jest-axe/tsconfig.json b/types/jest-axe/tsconfig.json index 1889f0045d..887813c869 100644 --- a/types/jest-axe/tsconfig.json +++ b/types/jest-axe/tsconfig.json @@ -2,8 +2,7 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es6", - "dom" + "es6" ], "noImplicitAny": true, "noImplicitThis": true, diff --git a/types/jest-axe/tslint.json b/types/jest-axe/tslint.json index 3db14f85ea..4f44991c3c 100644 --- a/types/jest-axe/tslint.json +++ b/types/jest-axe/tslint.json @@ -1 +1,6 @@ -{ "extends": "dtslint/dt.json" } +{ + "extends": "dtslint/dt.json", + "rules": { + "no-empty-interface": false + } +} From 59556135337adb342da06bd2bd36a379bf8584e0 Mon Sep 17 00:00:00 2001 From: Waseem Dahman Date: Sat, 27 Oct 2018 21:42:50 -0400 Subject: [PATCH 3/3] declare a global Node --- types/jest-axe/index.d.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/types/jest-axe/index.d.ts b/types/jest-axe/index.d.ts index 7398572bb1..60375e3605 100644 --- a/types/jest-axe/index.d.ts +++ b/types/jest-axe/index.d.ts @@ -8,10 +8,6 @@ import { AxeResults, Result, RunOnly } from "axe-core"; -declare module "axe-core" { - interface Node {} -} - /** * Version of the aXe verifier with defaults set. * @@ -86,4 +82,7 @@ declare global { toHaveNoViolations: IToHaveNoViolations; } } + + // axe-core depends on a global Node + interface Node {} }