From b54b6980a0cfb4d9a19dd4efec9eed645d0ed0dd Mon Sep 17 00:00:00 2001 From: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Date: Tue, 10 Sep 2019 22:38:47 -0700 Subject: [PATCH] [@types/node] Http2ServerResponse extends Stream (#37812) * [@types/node][v10] Http2ServerResponse extends Stream This was fixed in newer versions in #33527 but got missed in v10 * [@types/node][v8+v9] Http2ServerResponse extends Stream * Added trivikr@ in Definitions by for @types/node --- types/node/index.d.ts | 1 + types/node/v10/http2.d.ts | 2 +- types/node/v8/base.d.ts | 2 +- types/node/v9/base.d.ts | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/types/node/index.d.ts b/types/node/index.d.ts index 90f672d03c..e04485bfcb 100644 --- a/types/node/index.d.ts +++ b/types/node/index.d.ts @@ -37,6 +37,7 @@ // Jordi Oliveras Rovira // Thanik Bhongbhibhat // Marcin Kopacz +// Trivikram Kamat // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // NOTE: These definitions support NodeJS and TypeScript 3.2. diff --git a/types/node/v10/http2.d.ts b/types/node/v10/http2.d.ts index 06ebb77b7b..3d65f19cd5 100644 --- a/types/node/v10/http2.d.ts +++ b/types/node/v10/http2.d.ts @@ -556,7 +556,7 @@ declare module "http2" { prependOnceListener(event: "aborted", listener: (hadError: boolean, code: number) => void): this; } - export class Http2ServerResponse extends events.EventEmitter { + export class Http2ServerResponse extends stream.Stream { private constructor(); addTrailers(trailers: OutgoingHttpHeaders): void; connection: net.Socket | tls.TLSSocket; diff --git a/types/node/v8/base.d.ts b/types/node/v8/base.d.ts index ce27943e22..2c80ce48ab 100644 --- a/types/node/v8/base.d.ts +++ b/types/node/v8/base.d.ts @@ -6792,7 +6792,7 @@ declare module "http2" { prependOnceListener(event: "aborted", listener: (hadError: boolean, code: number) => void): this; } - export class Http2ServerResponse extends events.EventEmitter { + export class Http2ServerResponse extends stream.Stream { private constructor(); addTrailers(trailers: OutgoingHttpHeaders): void; connection: net.Socket | tls.TLSSocket; diff --git a/types/node/v9/base.d.ts b/types/node/v9/base.d.ts index 533f8f72d2..b65590eb4d 100644 --- a/types/node/v9/base.d.ts +++ b/types/node/v9/base.d.ts @@ -7213,7 +7213,7 @@ declare module "http2" { prependOnceListener(event: "aborted", listener: (hadError: boolean, code: number) => void): this; } - export class Http2ServerResponse extends events.EventEmitter { + export class Http2ServerResponse extends stream.Stream { private constructor(); addTrailers(trailers: OutgoingHttpHeaders): void; connection: net.Socket | tls.TLSSocket;