From 1a85a336e38f4cc007c576b3acb703dc3455517d Mon Sep 17 00:00:00 2001 From: Ryan Clark Date: Sat, 2 Jun 2018 03:43:58 +0100 Subject: [PATCH 1/4] Make serve property optional on webpack config --- types/webpack-serve/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/webpack-serve/index.d.ts b/types/webpack-serve/index.d.ts index 8e597097a7..222b8d8f09 100644 --- a/types/webpack-serve/index.d.ts +++ b/types/webpack-serve/index.d.ts @@ -16,7 +16,7 @@ export = WebpackServe; declare module 'webpack' { interface Configuration { - serve: WebpackServe.Options; + serve?: WebpackServe.Options; } } From ad2163b71c260f234e3c8a7294b8e1762e50d15f Mon Sep 17 00:00:00 2001 From: Ryan Clark Date: Sat, 2 Jun 2018 04:17:18 +0100 Subject: [PATCH 2/4] Change node API to accept the full webpack config --- types/webpack-serve/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/webpack-serve/index.d.ts b/types/webpack-serve/index.d.ts index 222b8d8f09..5a1a302af0 100644 --- a/types/webpack-serve/index.d.ts +++ b/types/webpack-serve/index.d.ts @@ -21,7 +21,7 @@ declare module 'webpack' { } declare function WebpackServe( - { config }: { config: WebpackServe.Options } + { config }: { config: webpack.Configuration } ): Promise; declare namespace WebpackServe { From 3f71e50e9ae4ba133ee8c2c6e42482a3d3b4f5e8 Mon Sep 17 00:00:00 2001 From: Ryan Clark Date: Sat, 2 Jun 2018 05:02:36 +0100 Subject: [PATCH 3/4] Fix tests --- types/webpack-serve/webpack-serve-tests.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/types/webpack-serve/webpack-serve-tests.ts b/types/webpack-serve/webpack-serve-tests.ts index fff9668b29..551072926c 100644 --- a/types/webpack-serve/webpack-serve-tests.ts +++ b/types/webpack-serve/webpack-serve-tests.ts @@ -5,13 +5,15 @@ const compiler = webpack(); const server = serve({ config: { - http2: true, - dev: { - publicPath: '/', - logLevel: 'info' + serve: { + http2: true, + dev: { + publicPath: '/', + logLevel: 'info' + }, + host: 'localhost' }, - host: 'localhost' - } + }. }); server From 2e23a68431898e85576a9bd36665872583723656 Mon Sep 17 00:00:00 2001 From: Ryan Clark Date: Sat, 2 Jun 2018 07:47:54 +0100 Subject: [PATCH 4/4] Fix typo --- types/webpack-serve/webpack-serve-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/webpack-serve/webpack-serve-tests.ts b/types/webpack-serve/webpack-serve-tests.ts index 551072926c..2a29cec317 100644 --- a/types/webpack-serve/webpack-serve-tests.ts +++ b/types/webpack-serve/webpack-serve-tests.ts @@ -13,7 +13,7 @@ const server = serve({ }, host: 'localhost' }, - }. + }, }); server