From b71b75d31d85efe7e1283a24309fc2a173cc47f9 Mon Sep 17 00:00:00 2001 From: Tim van Halteren <9273697+Halt001@users.noreply.github.com> Date: Tue, 10 Oct 2017 21:55:18 +0200 Subject: [PATCH] @types/sinon: Added sinon.createSandbox and sinon.defaultConfig (#20451) * Added sinon.createSandbox and sinon.defaultConfig * Combined sandbox.create() and createSandbox() overloads using optional parameter --- types/sinon/index.d.ts | 5 +++-- types/sinon/sinon-tests.ts | 14 ++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/types/sinon/index.d.ts b/types/sinon/index.d.ts index d037362659..f8258efc95 100644 --- a/types/sinon/index.d.ts +++ b/types/sinon/index.d.ts @@ -494,11 +494,12 @@ declare namespace Sinon { } interface SinonSandboxStatic { - create(): SinonSandbox; - create(config: SinonSandboxConfig): SinonSandbox; + create(config?: SinonSandboxConfig): SinonSandbox; } interface SinonStatic { + createSandbox(config?: SinonSandboxConfig): SinonSandbox; + defaultConfig: SinonSandboxConfig; sandbox: SinonSandboxStatic; } diff --git a/types/sinon/sinon-tests.ts b/types/sinon/sinon-tests.ts index b0a12c02ea..33ac93f595 100644 --- a/types/sinon/sinon-tests.ts +++ b/types/sinon/sinon-tests.ts @@ -97,7 +97,21 @@ function testAssert() { } function testSandbox() { + const config = { + injectInto: null, + properties: ["spy", "stub", "mock", "clock", "server", "requests"], + useFakeServer: true, + useFakeTimers: true, + }; + let sandbox = sinon.sandbox.create(); + sandbox = sinon.sandbox.create(config); + sandbox = sinon.sandbox.create(sinon.defaultConfig); + + sandbox = sinon.createSandbox(); + sandbox = sinon.createSandbox(config); + sandbox = sinon.createSandbox(sinon.defaultConfig); + sandbox = sandbox.usingPromise(Promise); sandbox.assert.notCalled(sinon.spy());