From d498719558e4d1a94b726069d6a086b77f08e62b Mon Sep 17 00:00:00 2001 From: Mike Date: Tue, 15 Jan 2019 00:37:20 -0800 Subject: [PATCH 1/2] handle clear --- types/flatbuffers/flatbuffers-tests.ts | 21 +++++++++++++++++++++ types/flatbuffers/index.d.ts | 8 ++++++++ 2 files changed, 29 insertions(+) diff --git a/types/flatbuffers/flatbuffers-tests.ts b/types/flatbuffers/flatbuffers-tests.ts index 13f8453224..4f1c164424 100644 --- a/types/flatbuffers/flatbuffers-tests.ts +++ b/types/flatbuffers/flatbuffers-tests.ts @@ -86,6 +86,27 @@ class Test { builder.writeInt16(a); return builder.offset(); } + + static testClear(builder: flatbuffers.Builder, a: number, b: number) { + let offsets: number[] = []; + let iterations = 100; + for (let i = 0; i < iterations; i++) { + let offset = Test.createTest(builder, a, b); + offsets.push(offset); + builder.clear(); + } + + let lastOffsetValue = offsets[0]; + let sameValue = true; + for (let i = 1; i < offsets.length; i++) { + if (lastOffsetValue != offsets[i]) { + sameValue = false; + return sameValue; + } + lastOffsetValue = offsets[i]; + } + return sameValue; + } } class TestSimpleTableWithEnum { diff --git a/types/flatbuffers/index.d.ts b/types/flatbuffers/index.d.ts index bd74387bf2..b78fced515 100644 --- a/types/flatbuffers/index.d.ts +++ b/types/flatbuffers/index.d.ts @@ -42,6 +42,12 @@ declare global { class Builder { constructor(initial_size?: number); + /** + * Reset all the state in this FlatBufferBuilder + * so it can be reused to construct another buffer. + */ + clear(): void; + /** * In order to save space, fields that are set to their default value * don't get serialized into the buffer. Forcing defaults provides a @@ -211,6 +217,8 @@ declare global { static allocate(byte_size: number): ByteBuffer; + clear(): void; + bytes(): Uint8Array; position(): number; From 38b89475d32973a7bd361b5ef535feff817a9654 Mon Sep 17 00:00:00 2001 From: Mike Date: Tue, 15 Jan 2019 00:57:57 -0800 Subject: [PATCH 2/2] yup --- types/flatbuffers/flatbuffers-tests.ts | 8 ++++---- types/flatbuffers/index.d.ts | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/types/flatbuffers/flatbuffers-tests.ts b/types/flatbuffers/flatbuffers-tests.ts index 4f1c164424..030835c2c9 100644 --- a/types/flatbuffers/flatbuffers-tests.ts +++ b/types/flatbuffers/flatbuffers-tests.ts @@ -88,10 +88,10 @@ class Test { } static testClear(builder: flatbuffers.Builder, a: number, b: number) { - let offsets: number[] = []; - let iterations = 100; + const offsets: number[] = []; + const iterations = 100; for (let i = 0; i < iterations; i++) { - let offset = Test.createTest(builder, a, b); + const offset = Test.createTest(builder, a, b); offsets.push(offset); builder.clear(); } @@ -99,7 +99,7 @@ class Test { let lastOffsetValue = offsets[0]; let sameValue = true; for (let i = 1; i < offsets.length; i++) { - if (lastOffsetValue != offsets[i]) { + if (lastOffsetValue !== offsets[i]) { sameValue = false; return sameValue; } diff --git a/types/flatbuffers/index.d.ts b/types/flatbuffers/index.d.ts index b78fced515..03f3d952f3 100644 --- a/types/flatbuffers/index.d.ts +++ b/types/flatbuffers/index.d.ts @@ -43,8 +43,8 @@ declare global { constructor(initial_size?: number); /** - * Reset all the state in this FlatBufferBuilder - * so it can be reused to construct another buffer. + * Reset all the state in this FlatBufferBuilder + * so it can be reused to construct another buffer. */ clear(): void;