From bf4d3186fd705b889b351a2820a11dc326fd7bcd Mon Sep 17 00:00:00 2001 From: Terry Mun Date: Fri, 17 Aug 2018 11:24:57 +0200 Subject: [PATCH] Updated add/removeEventListener typings The add/removeEventListeners should accept a type that is defined by fscreen itself (6 possible string values instead of just `string`), and the optional options parameter should be of type `boolean` or `AddEventListenerOptions` instead of `boolean` only. --- types/fscreen/index.d.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/types/fscreen/index.d.ts b/types/fscreen/index.d.ts index bc1d3d3813..07f76dc8d8 100644 --- a/types/fscreen/index.d.ts +++ b/types/fscreen/index.d.ts @@ -5,6 +5,7 @@ type Handler = () => void; type RequestFullScreenFunction = (element: Element) => void; +type EventName = 'fullscreenEnabled' | 'fullscreenElement' | 'requestFullscreen' | 'exitFullscreen' | 'fullscreenchange' | 'fullscreenerror'; declare class Fscreen { readonly fullscreenElement: Element | undefined; @@ -13,8 +14,8 @@ declare class Fscreen { onfullscreenchange: Handler; onfullscreenerror: Handler; - addEventListener(type: string, handler: Handler, useCapture?: boolean): void; - removeEventListener(type: string, handler: Handler): void; + addEventListener(type: EventName, handler: Handler, options?: boolean | AddEventListenerOptions): void; + removeEventListener(type: EventName, handler: Handler, options?: boolean | AddEventListenerOptions): void; requestFullscreen(element: Element): void; requestFullscreenFunction(element: Element): RequestFullScreenFunction; }