From 7ea404d70bf96f7530d2f402913cc6a58317a383 Mon Sep 17 00:00:00 2001 From: "Adam A. Zerella" Date: Wed, 6 Mar 2019 15:49:56 +1100 Subject: [PATCH 1/6] Added type defs for is-date-object --- types/is-date-object/index.d.ts | 8 +++++++ types/is-date-object/is-date-object-tests.ts | 14 +++++++++++ types/is-date-object/tsconfig.json | 25 ++++++++++++++++++++ types/is-date-object/tslint.json | 3 +++ 4 files changed, 50 insertions(+) create mode 100644 types/is-date-object/index.d.ts create mode 100644 types/is-date-object/is-date-object-tests.ts create mode 100644 types/is-date-object/tsconfig.json create mode 100644 types/is-date-object/tslint.json diff --git a/types/is-date-object/index.d.ts b/types/is-date-object/index.d.ts new file mode 100644 index 0000000000..08885dce51 --- /dev/null +++ b/types/is-date-object/index.d.ts @@ -0,0 +1,8 @@ +// Type definitions for is-date-object 1.0 +// Project: https://github.com/ljharb/is-date-object +// Definitions by: Adam Zerella +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +declare function isDateObject(value?: any): boolean; + +export = isDateObject; diff --git a/types/is-date-object/is-date-object-tests.ts b/types/is-date-object/is-date-object-tests.ts new file mode 100644 index 0000000000..68fb22d684 --- /dev/null +++ b/types/is-date-object/is-date-object-tests.ts @@ -0,0 +1,14 @@ +import isDate = require("is-date-object"); + +isDate(); +isDate(undefined); +isDate(null); +isDate(false); +isDate(true); +isDate(42); +isDate('foo'); +isDate([]); +isDate({}); +isDate(/a/g); +isDate(new RegExp('a', 'g')); +isDate(new Date()); diff --git a/types/is-date-object/tsconfig.json b/types/is-date-object/tsconfig.json new file mode 100644 index 0000000000..7c42b57df2 --- /dev/null +++ b/types/is-date-object/tsconfig.json @@ -0,0 +1,25 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "strictFunctionTypes": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [ + + ], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "is-date-object-tests.ts" + ] +} diff --git a/types/is-date-object/tslint.json b/types/is-date-object/tslint.json new file mode 100644 index 0000000000..e60c15844f --- /dev/null +++ b/types/is-date-object/tslint.json @@ -0,0 +1,3 @@ +{ + "extends": "dtslint/dt.json" +} \ No newline at end of file From 56de1e479c09182b87d995775b1397dccebe6f0e Mon Sep 17 00:00:00 2001 From: "Adam A. Zerella" Date: Wed, 6 Mar 2019 16:17:47 +1100 Subject: [PATCH 2/6] Updated any type to unknown --- types/is-date-object/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/is-date-object/index.d.ts b/types/is-date-object/index.d.ts index 08885dce51..da3444ad91 100644 --- a/types/is-date-object/index.d.ts +++ b/types/is-date-object/index.d.ts @@ -2,7 +2,8 @@ // Project: https://github.com/ljharb/is-date-object // Definitions by: Adam Zerella // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 3.3 -declare function isDateObject(value?: any): boolean; +declare function isDateObject(value?: unknown): boolean; export = isDateObject; From 28e01537831d35cdafce4d4ac8e6cc89d413bc8f Mon Sep 17 00:00:00 2001 From: "Adam A. Zerella" Date: Wed, 6 Mar 2019 16:17:47 +1100 Subject: [PATCH 3/6] Updated any type to unknown --- types/is-date-object/index.d.ts | 6 +++++- types/is-date-object/is-date-object-tests.ts | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/types/is-date-object/index.d.ts b/types/is-date-object/index.d.ts index da3444ad91..4564b5e34b 100644 --- a/types/is-date-object/index.d.ts +++ b/types/is-date-object/index.d.ts @@ -4,6 +4,10 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 3.3 -declare function isDateObject(value?: unknown): boolean; +type InvalidTypes = undefined | null | boolean | string | number | [] | {}; + +declare function isDateObject(value: Date): true; +declare function isDateObject(value: InvalidTypes | unknown): false; +declare function isDateObject(value?: unknown): false; export = isDateObject; diff --git a/types/is-date-object/is-date-object-tests.ts b/types/is-date-object/is-date-object-tests.ts index 68fb22d684..9946c42d54 100644 --- a/types/is-date-object/is-date-object-tests.ts +++ b/types/is-date-object/is-date-object-tests.ts @@ -7,6 +7,7 @@ isDate(false); isDate(true); isDate(42); isDate('foo'); +isDate((): void => {}); isDate([]); isDate({}); isDate(/a/g); From 0454d3a6a6c0c4559e55752091b41512737131b5 Mon Sep 17 00:00:00 2001 From: "Adam A. Zerella" Date: Thu, 7 Mar 2019 12:18:39 +1100 Subject: [PATCH 4/6] Updated return type for unknown param value --- types/is-date-object/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/is-date-object/index.d.ts b/types/is-date-object/index.d.ts index 4564b5e34b..55865a2a2e 100644 --- a/types/is-date-object/index.d.ts +++ b/types/is-date-object/index.d.ts @@ -7,7 +7,7 @@ type InvalidTypes = undefined | null | boolean | string | number | [] | {}; declare function isDateObject(value: Date): true; -declare function isDateObject(value: InvalidTypes | unknown): false; -declare function isDateObject(value?: unknown): false; +declare function isDateObject(value: InvalidTypes | unknown): boolean; +declare function isDateObject(value?: unknown): boolean; export = isDateObject; From 2bbab68802af8be26a4f268f25764bc7f7c80c32 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Thu, 7 Mar 2019 13:57:30 +1100 Subject: [PATCH 5/6] Update types/is-date-object/index.d.ts Co-Authored-By: adamzerella --- types/is-date-object/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/is-date-object/index.d.ts b/types/is-date-object/index.d.ts index 55865a2a2e..3ad24b15af 100644 --- a/types/is-date-object/index.d.ts +++ b/types/is-date-object/index.d.ts @@ -8,6 +8,7 @@ type InvalidTypes = undefined | null | boolean | string | number | [] | {}; declare function isDateObject(value: Date): true; declare function isDateObject(value: InvalidTypes | unknown): boolean; -declare function isDateObject(value?: unknown): boolean; +declare function isDateObject(value?: object): boolean; +declare function isDateObject(value?: null | undefined | boolean | string | number | symbol | bigint | Array | Function): false; export = isDateObject; From b11d95d4336819d9f36703248bd87b6772e30ee1 Mon Sep 17 00:00:00 2001 From: Adam Zerella Date: Thu, 7 Mar 2019 13:58:48 +1100 Subject: [PATCH 6/6] Update index.d.ts --- types/is-date-object/index.d.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/types/is-date-object/index.d.ts b/types/is-date-object/index.d.ts index 3ad24b15af..52b2f3ac84 100644 --- a/types/is-date-object/index.d.ts +++ b/types/is-date-object/index.d.ts @@ -4,10 +4,7 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 3.3 -type InvalidTypes = undefined | null | boolean | string | number | [] | {}; - declare function isDateObject(value: Date): true; -declare function isDateObject(value: InvalidTypes | unknown): boolean; declare function isDateObject(value?: object): boolean; declare function isDateObject(value?: null | undefined | boolean | string | number | symbol | bigint | Array | Function): false;