From 9d060ae3fac10cecc5c3121fd6b3b7263193a6e0 Mon Sep 17 00:00:00 2001 From: Ville Saarinen Date: Mon, 6 Feb 2017 17:15:28 +0200 Subject: [PATCH 1/2] Third parameter to branch() should be optional This is in line with the API documentation, e.g. the example for renderComponent(): https://github.com/acdlite/recompose/blob/master/docs/API.md#rendercomponent --- recompose/index.d.ts | 2 +- recompose/recompose-tests.tsx | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/recompose/index.d.ts b/recompose/index.d.ts index e72302415f..bed45744aa 100644 --- a/recompose/index.d.ts +++ b/recompose/index.d.ts @@ -103,7 +103,7 @@ declare module 'recompose' { export function branch( test: predicate, trueEnhancer: InferableComponentEnhancer, - falseEnhancer: InferableComponentEnhancer + falseEnhancer?: InferableComponentEnhancer ): ComponentEnhancer; // renderComponent: https://github.com/acdlite/recompose/blob/master/docs/API.md#renderComponent diff --git a/recompose/recompose-tests.tsx b/recompose/recompose-tests.tsx index 25b52d70b0..c4c66b3e2c 100644 --- a/recompose/recompose-tests.tsx +++ b/recompose/recompose-tests.tsx @@ -148,13 +148,19 @@ function testBranch() { const innerComponent: React.StatelessComponent = (props: InnerProps) =>
props.update()}>{props.count}
; + const innerComponent2 = () =>
Hello
; const enhancer = branch( (props: OutterProps) => props.toggled, withState("count", "update", 0), withState("count", "update", 100) ); + const enhancer2 = branch( + (props: OutterProps) => props.toggled, + renderComponent(innerComponent), + ) const enhanced: React.ComponentClass = enhancer(innerComponent); + const enhanced2: React.ComponentClass = enhancer2(innerComponent); } function testRenderComponent() { From dffc2b7078db3295252a646dce2697a00552f1a3 Mon Sep 17 00:00:00 2001 From: Ville Saarinen Date: Mon, 6 Feb 2017 17:19:33 +0200 Subject: [PATCH 2/2] Increase version number --- recompose/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recompose/index.d.ts b/recompose/index.d.ts index bed45744aa..3ff504fab3 100644 --- a/recompose/index.d.ts +++ b/recompose/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for Recompose v0.20.2 +// Type definitions for Recompose v0.20.3 // Project: https://github.com/acdlite/recompose // Definitions by: Iskander Sierra // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped