From 4de9ed7c8e0ac6af0393f280a3b356d4de0b8a01 Mon Sep 17 00:00:00 2001
From: Luis Herranz <luisherranz@gmail.com>
Date: Wed, 10 Apr 2019 13:29:08 +0200
Subject: [PATCH 1/6] add attributes to get functions

---
 types/loadable__server/index.d.ts              | 12 ++++++------
 .../loadable__server-tests.tsx                 | 18 ++++++++++++++++++
 2 files changed, 24 insertions(+), 6 deletions(-)

diff --git a/types/loadable__server/index.d.ts b/types/loadable__server/index.d.ts
index 33a3366ca9..74999820d2 100644
--- a/types/loadable__server/index.d.ts
+++ b/types/loadable__server/index.d.ts
@@ -51,32 +51,32 @@ export class ChunkExtractor {
 	/**
 	 * Get scripts as a string of `<script>` tags
 	 */
-	getScriptTags(): string;
+	getScriptTags(attributes?: { [key: string]: string }): string;
 
 	/**
 	 * Get scripts as an array of React `<script>` elements.
 	 */
-	getScriptElements(): Array<ReactElement<{}>>;
+  	getScriptElements(attributes?: { [key: string]: string }): Array<ReactElement<{}>>;
 
 	/**
 	 * Get "prefetch" and "preload" links as a string of `<link>` tags
 	 */
-	getLinkTags(): string;
+  	getLinkTags(attributes?: { [key: string]: string }): string;
 
 	/**
 	 * Get "prefetch" and "preload" links as an array of React `<link>` elements
 	 */
-	getLinkElements(): Array<ReactElement<{}>>;
+  	getLinkElements(attributes?: { [key: string]: string }): Array<ReactElement<{}>>;
 
 	/**
 	 * Get style links as a string of `<link>` tags
 	 */
-	getStyleTags(): string;
+  	getStyleTags(attributes?: { [key: string]: string }): string;
 
 	/**
 	 * Get style links as an array of React `<link>` elements
 	 */
-	getStyleElements(): Array<ReactElement<{}>>;
+  	getStyleElements(attributes?: { [key: string]: string }): Array<ReactElement<{}>>;
 }
 
 export interface ChunkExtractorManagerProps {
diff --git a/types/loadable__server/loadable__server-tests.tsx b/types/loadable__server/loadable__server-tests.tsx
index 7e1649b282..b34f47e47e 100644
--- a/types/loadable__server/loadable__server-tests.tsx
+++ b/types/loadable__server/loadable__server-tests.tsx
@@ -25,40 +25,58 @@ const {
     const jsx: JSX.Element = collectChunks(<div>Test</div>);
 }
 
+// Some example attributes for get functions.
+const attributes = {
+    type: "module",
+    "data-type": "loadable"
+};
+
 // getLinkElements
 {
     // Should return an array of React elements
     const elements: Array<React.ReactElement<{}>> = getLinkElements();
+    const elementsWithAttrs: Array<React.ReactElement<{}>> = getLinkElements(
+        attributes
+    );
 }
 
 // getLinkTags
 {
     // Should return a string
     const tags: string = getLinkTags();
+    const tagsWithAttrs: string = getLinkTags(attributes);
 }
 
 // getScriptElements
 {
     // Should return an array of React elements
     const elements: Array<React.ReactElement<{}>> = getScriptElements();
+    const elementsWithAttrs: Array<React.ReactElement<{}>> = getScriptElements(
+        attributes
+    );
 }
 
 // getScriptTags
 {
     // Should return a string
     const tags: string = getScriptTags();
+    const tagsWithAttrs: string = getScriptTags(attributes);
 }
 
 // getStyleElements
 {
     // Should return an array of React elements
     const elements: Array<React.ReactElement<{}>> = getStyleElements();
+    const elementsWithAttrs: Array<React.ReactElement<{}>> = getStyleElements(
+        attributes
+    );
 }
 
 // getStyleTags
 {
     // Should return a string
     const tags: string = getStyleTags();
+    const tagsWithAttrs: string = getStyleTags(attributes);
 }
 
 // requireEntrypoint

From dd67b0c76ece62bb3da722ee389b5abc859cb616 Mon Sep 17 00:00:00 2001
From: Luis Herranz <luisherranz@gmail.com>
Date: Wed, 10 Apr 2019 13:43:59 +0200
Subject: [PATCH 2/6] increase version number (minor)

---
 types/loadable__server/index.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/types/loadable__server/index.d.ts b/types/loadable__server/index.d.ts
index 74999820d2..a77cdd5f9a 100644
--- a/types/loadable__server/index.d.ts
+++ b/types/loadable__server/index.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for @loadable/server 5.2
+// Type definitions for @loadable/server 5.3
 // Project: https://github.com/smooth-code/loadable-components
 // Definitions by: Martynas Kadiša <https://github.com/martynaskadisa>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped

From b766a9b8b7650d1399a7d07cd7bd04617e8e28be Mon Sep 17 00:00:00 2001
From: Luis Herranz <luisherranz@gmail.com>
Date: Wed, 10 Apr 2019 15:37:06 +0200
Subject: [PATCH 3/6] add myself in definitions

---
 types/loadable__server/index.d.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/types/loadable__server/index.d.ts b/types/loadable__server/index.d.ts
index a77cdd5f9a..db51e8beb5 100644
--- a/types/loadable__server/index.d.ts
+++ b/types/loadable__server/index.d.ts
@@ -1,6 +1,7 @@
 // Type definitions for @loadable/server 5.3
 // Project: https://github.com/smooth-code/loadable-components
 // Definitions by: Martynas Kadiša <https://github.com/martynaskadisa>
+//                 Luis Herranz <https://github.com/luisherranz>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 // TypeScript Version: 2.8
 

From 1379ee5ebd1461e16393c2047c7df4672878998f Mon Sep 17 00:00:00 2001
From: Luis Herranz <luisherranz@gmail.com>
Date: Thu, 11 Apr 2019 15:50:54 +0200
Subject: [PATCH 4/6] switch to regular object for attributes and add attribute
 function

---
 types/loadable__server/index.d.ts             | 30 +++++++++++++++----
 .../loadable__server-tests.tsx                | 27 ++++++++++++++++-
 2 files changed, 50 insertions(+), 7 deletions(-)

diff --git a/types/loadable__server/index.d.ts b/types/loadable__server/index.d.ts
index db51e8beb5..ba13e1182c 100644
--- a/types/loadable__server/index.d.ts
+++ b/types/loadable__server/index.d.ts
@@ -28,6 +28,24 @@ export type ChunkExtractorOptions = {
 	stats: object;
  });
 
+/**
+ * Chunk that is received by the AttrFn function.
+ */
+export interface Chunk {
+	chunk: string;
+	filename: string;
+	linkType: string;
+	path: string;
+	scriptType: string;
+	type: string;
+	url: string;
+}
+
+/**
+ * Used to insert attributes in the get functions.
+ */
+export type AttrFn = (chunk: Chunk) => {};
+
 /**
  * Used to collect chunks server-side and get them as script tags or script elements
  */
@@ -52,32 +70,32 @@ export class ChunkExtractor {
 	/**
 	 * Get scripts as a string of `<script>` tags
 	 */
-	getScriptTags(attributes?: { [key: string]: string }): string;
+	getScriptTags(attr?: {} | AttrFn): string;
 
 	/**
 	 * Get scripts as an array of React `<script>` elements.
 	 */
-  	getScriptElements(attributes?: { [key: string]: string }): Array<ReactElement<{}>>;
+  	getScriptElements(attr?: {} | AttrFn): Array<ReactElement<{}>>;
 
 	/**
 	 * Get "prefetch" and "preload" links as a string of `<link>` tags
 	 */
-  	getLinkTags(attributes?: { [key: string]: string }): string;
+  	getLinkTags(attr?: {} | AttrFn): string;
 
 	/**
 	 * Get "prefetch" and "preload" links as an array of React `<link>` elements
 	 */
-  	getLinkElements(attributes?: { [key: string]: string }): Array<ReactElement<{}>>;
+  	getLinkElements(attr?: {} | AttrFn): Array<ReactElement<{}>>;
 
 	/**
 	 * Get style links as a string of `<link>` tags
 	 */
-  	getStyleTags(attributes?: { [key: string]: string }): string;
+  	getStyleTags(attr?: {} | AttrFn): string;
 
 	/**
 	 * Get style links as an array of React `<link>` elements
 	 */
-  	getStyleElements(attributes?: { [key: string]: string }): Array<ReactElement<{}>>;
+  	getStyleElements(attr?: {} | AttrFn): Array<ReactElement<{}>>;
 }
 
 export interface ChunkExtractorManagerProps {
diff --git a/types/loadable__server/loadable__server-tests.tsx b/types/loadable__server/loadable__server-tests.tsx
index b34f47e47e..cfd3917086 100644
--- a/types/loadable__server/loadable__server-tests.tsx
+++ b/types/loadable__server/loadable__server-tests.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { ChunkExtractor } from '@loadable/server';
+import { ChunkExtractor, AttrFn } from '@loadable/server';
 
 // Should be satisfied by `stats` or `statsFile`
 new ChunkExtractor({ stats: {} });
@@ -31,6 +31,19 @@ const attributes = {
     "data-type": "loadable"
 };
 
+// An attribute function for get functions.
+const attrFn: AttrFn = (chunk) => {
+    return {
+        chunk: chunk.chunk,
+        filename: chunk.filename,
+        linkType: chunk.linkType,
+        path: chunk.path,
+        scriptType: chunk.scriptType,
+        type: chunk.type,
+        url: chunk.url
+    };
+};
+
 // getLinkElements
 {
     // Should return an array of React elements
@@ -38,6 +51,9 @@ const attributes = {
     const elementsWithAttrs: Array<React.ReactElement<{}>> = getLinkElements(
         attributes
     );
+    const elementsWithAttrFn: Array<React.ReactElement<{}>> = getLinkElements(
+        attrFn
+    );
 }
 
 // getLinkTags
@@ -45,6 +61,7 @@ const attributes = {
     // Should return a string
     const tags: string = getLinkTags();
     const tagsWithAttrs: string = getLinkTags(attributes);
+    const tagsWithAttrFn: string = getLinkTags(attrFn);
 }
 
 // getScriptElements
@@ -54,6 +71,9 @@ const attributes = {
     const elementsWithAttrs: Array<React.ReactElement<{}>> = getScriptElements(
         attributes
     );
+    const elementsWithAttrFn: Array<React.ReactElement<{}>> = getScriptElements(
+        attrFn
+    );
 }
 
 // getScriptTags
@@ -61,6 +81,7 @@ const attributes = {
     // Should return a string
     const tags: string = getScriptTags();
     const tagsWithAttrs: string = getScriptTags(attributes);
+    const tagsWithAttrFn: string = getScriptTags(attrFn);
 }
 
 // getStyleElements
@@ -70,6 +91,9 @@ const attributes = {
     const elementsWithAttrs: Array<React.ReactElement<{}>> = getStyleElements(
         attributes
     );
+    const elementsWithAttrFn: Array<React.ReactElement<{}>> = getStyleElements(
+        attrFn
+    );
 }
 
 // getStyleTags
@@ -77,6 +101,7 @@ const attributes = {
     // Should return a string
     const tags: string = getStyleTags();
     const tagsWithAttrs: string = getStyleTags(attributes);
+    const tagsWithAttrFn: string = getStyleTags(attrFn);
 }
 
 // requireEntrypoint

From 52c26de82f1baef4d670a84ee73c5fa61ed75d8f Mon Sep 17 00:00:00 2001
From: Luis Herranz <luisherranz@gmail.com>
Date: Thu, 11 Apr 2019 18:24:52 +0200
Subject: [PATCH 5/6] change number to match library version

---
 types/loadable__server/index.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/types/loadable__server/index.d.ts b/types/loadable__server/index.d.ts
index ba13e1182c..da6c226fdc 100644
--- a/types/loadable__server/index.d.ts
+++ b/types/loadable__server/index.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for @loadable/server 5.3
+// Type definitions for @loadable/server 5.8.0
 // Project: https://github.com/smooth-code/loadable-components
 // Definitions by: Martynas Kadiša <https://github.com/martynaskadisa>
 //                 Luis Herranz <https://github.com/luisherranz>

From ab54e2bb19243722ef4e65001d3cd29783a84c6b Mon Sep 17 00:00:00 2001
From: Luis Herranz <luisherranz@gmail.com>
Date: Thu, 11 Apr 2019 19:46:21 +0200
Subject: [PATCH 6/6] remove patch from version

---
 types/loadable__server/index.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/types/loadable__server/index.d.ts b/types/loadable__server/index.d.ts
index da6c226fdc..01428eea4b 100644
--- a/types/loadable__server/index.d.ts
+++ b/types/loadable__server/index.d.ts
@@ -1,4 +1,4 @@
-// Type definitions for @loadable/server 5.8.0
+// Type definitions for @loadable/server 5.8
 // Project: https://github.com/smooth-code/loadable-components
 // Definitions by: Martynas Kadiša <https://github.com/martynaskadisa>
 //                 Luis Herranz <https://github.com/luisherranz>