From 8864681db077703f359e779c1d65135d25edbccb Mon Sep 17 00:00:00 2001 From: MatejQ Date: Fri, 23 Oct 2015 15:34:53 +0200 Subject: [PATCH 1/2] Fixed CellClassGetter interfaces according to ui-grid JS code --- ui-grid/ui-grid.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui-grid/ui-grid.d.ts b/ui-grid/ui-grid.d.ts index ef013fdf18..bcf6efe7e0 100644 --- a/ui-grid/ui-grid.d.ts +++ b/ui-grid/ui-grid.d.ts @@ -3752,7 +3752,7 @@ declare module uiGrid { } export interface ICellClassGetter { - (gridRow?: IGridRowOf, gridCol?: IGridColumnOf, colRenderIndex?: number): string; + (grid?: IGridInstanceOf, gridRow?: IGridRowOf, gridCol?: IGridColumnOf, rowRenderIndex?: number, colRenderIndex?: number): string; } export interface ICellTooltipGetter { @@ -3762,7 +3762,7 @@ declare module uiGrid { (gridCol: IGridColumnOf): string; } export interface IHeaderFooterCellClassGetter { - (gridRow: IGridRowOf, rowRenderIndex: number, gridCol: IGridColumnOf, colRenderIndex: number) + (grid: IGridInstanceOf, gridRow: IGridRowOf, gridCol: IGridColumnOf, rowRenderIndex: number, colRenderIndex: number) : string; } export interface IMenuItem { From 19e1e0847b972660738b2720a0bca867ffd399c1 Mon Sep 17 00:00:00 2001 From: MatejQ Date: Fri, 23 Oct 2015 15:56:04 +0200 Subject: [PATCH 2/2] Attempt to fix failing tests. --- ui-grid/ui-grid-tests.ts | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ui-grid/ui-grid-tests.ts b/ui-grid/ui-grid-tests.ts index 95c81298a7..fe88fec4f2 100644 --- a/ui-grid/ui-grid-tests.ts +++ b/ui-grid/ui-grid-tests.ts @@ -12,9 +12,9 @@ columnDef.aggregationHideLabel = false; columnDef.aggregationType = 1; columnDef.aggregationType = function () { return 1; }; columnDef.cellClass = 'test'; -columnDef.cellClass = (gridRow, gridCol, index) => { - //types of gridRow, gridCol, and index are flowed in correctly - return `${gridRow.entity.name}-${gridCol.field}-${index + 1}`; +columnDef.cellClass = (grid, gridRow, gridCol, rowIndex, colIndex) => { + //types of grid, gridRow, gridCol, rowIndex and colIndex are flowed in correctly + return `${grid.footerHeight}-${gridRow.entity.name}-${gridCol.field}-${rowIndex + 1}-${colIndex + 1}`; }; columnDef.cellFilter = 'date'; columnDef.cellTemplate = '
hello
'; @@ -44,17 +44,17 @@ columnDef.filter = { columnDef.filterCellFiltered = false; columnDef.filterHeaderTemplate = '
'; columnDef.filters = [columnDef.filter]; -columnDef.footerCellClass = (gridRow, rowRenderIndex, gridCol, colRenderIndex) => { - //types for gridRow, rowRenderIndex, gridCol, and colRenderIndex flow in properly - return `${gridRow.entity.age}-${rowRenderIndex + 1}-${gridCol.field}-${colRenderIndex - 1}`; +columnDef.footerCellClass = (grid, gridRow, gridCol, rowRenderIndex, colRenderIndex) => { + //types for grid, gridRow, gridCol, rowRenderIndex, and colRenderIndex flow in properly + return `${grid.footerHeight}-${gridRow.entity.age}-${rowRenderIndex + 1}-${gridCol.field}-${colRenderIndex - 1}`; }; columnDef.footerCellClass = 'theClass'; columnDef.footerCellFilter = 'currency:$'; columnDef.footerCellTemplate = '
'; columnDef.headerCellClass = - (gridRow, rowRenderIndex, gridCol, colRenderIndex) => { - //types for gridRow, rowRenderIndex, gridCol, and colRenderIndex flow in properly - return `${gridRow.entity.age}-${rowRenderIndex + 1}-${gridCol.field}-${colRenderIndex - 1}`; + (grid, gridRow, gridCol, rowRenderIndex, colRenderIndex) => { + //types for grid, gridRow, gridCol, rowRenderIndex, and colRenderIndex flow in properly + return `${grid.footerHeight}-${gridRow.entity.age}-${rowRenderIndex + 1}-${gridCol.field}-${colRenderIndex - 1}`; }; columnDef.headerCellClass = 'classy'; columnDef.headerCellFilter = 'currency:$';