From d80f2e301ef22d4309027468b684a6d4bd4948c4 Mon Sep 17 00:00:00 2001 From: hovvahan94 Date: Tue, 15 Nov 2016 16:00:52 +0400 Subject: [PATCH 01/17] Update react-day-picker.d.ts --- react-day-picker/react-day-picker.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/react-day-picker/react-day-picker.d.ts b/react-day-picker/react-day-picker.d.ts index c9714261e3..a2ad472e43 100644 --- a/react-day-picker/react-day-picker.d.ts +++ b/react-day-picker/react-day-picker.d.ts @@ -67,6 +67,7 @@ declare namespace ReactDayPicker { numberOfMonths?: number; renderDay?: (date: Date) => number | string | JSX.Element; enableOutsideDays?: boolean; + firstDayOfWeek?:number; canChangeMonth?: boolean; disabledDays?: (date: Date) => boolean; fixedWeeks?: boolean; From 8d44b7df0e8a4f28faad0aa5c25bc7d484949c54 Mon Sep 17 00:00:00 2001 From: "Derek C. Finlinson" Date: Tue, 15 Nov 2016 13:37:36 -0700 Subject: [PATCH 02/17] Update SuccessCallbackDelegate definition --- xrm/xrm.d.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xrm/xrm.d.ts b/xrm/xrm.d.ts index 986ce7e78a..1d8aa521ff 100644 --- a/xrm/xrm.d.ts +++ b/xrm/xrm.d.ts @@ -483,8 +483,10 @@ declare namespace Xrm { /** * Called when the operation is successful. + * Currently, only the Xrm.Utility.openQuickCreate successCallback + * is passed a parameter so an optional parameter for it is included */ - export type SuccessCallbackDelegate = ( object: any ) => void; + export type SuccessCallbackDelegate = ( savedEntityReference?: Page.LookupValue ) => void; /** * Called when the operation fails. From a90abe4d4f067c2cbb6274ee97762f35fb2d276c Mon Sep 17 00:00:00 2001 From: "Derek C. Finlinson" Date: Tue, 15 Nov 2016 13:49:12 -0700 Subject: [PATCH 03/17] Fix ErrorCallbackDelegate signature --- xrm/xrm-tests.ts | 2 +- xrm/xrm.d.ts | 14 +++++++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/xrm/xrm-tests.ts b/xrm/xrm-tests.ts index ac0f115154..64fb9e8c22 100644 --- a/xrm/xrm-tests.ts +++ b/xrm/xrm-tests.ts @@ -72,7 +72,7 @@ if (Xrm.Page.data.process != null) /// Demonstrate v7.1 Quick Create form -Xrm.Utility.openQuickCreate("account").then(( newRecord: Xrm.Page.LookupValue ) => { alert( `Newly created record Id: ${newRecord.id}` ); }, (code, message) => {console.log(message)}); +Xrm.Utility.openQuickCreate("account").then(( newRecord: Xrm.Page.LookupValue ) => { alert( `Newly created record Id: ${newRecord.id}` ); }, (error) => {console.log(`Code: ${error.errorCode}, Message: ${error.message}`)}); /// Make all controls visible. diff --git a/xrm/xrm.d.ts b/xrm/xrm.d.ts index ff42d8f005..b78174523a 100644 --- a/xrm/xrm.d.ts +++ b/xrm/xrm.d.ts @@ -481,6 +481,15 @@ declare namespace Xrm */ export module Async { + /** + * Object passed to ErrorCallbackDelegate + */ + export interface ErrorCallbackObject + { + errorCode: number; + message: string; + } + /** * Called when the operation is successful. * Currently, only the Xrm.Utility.openQuickCreate successCallback @@ -491,10 +500,9 @@ declare namespace Xrm /** * Called when the operation fails. * - * @param {number} errorCode The error code. - * @param {string} message The message. + * @param {ErrorCallbackObject} error The error object */ - export type ErrorCallbackDelegate = ( errorCode: number, message: string ) => void; + export type ErrorCallbackDelegate = ( error: ErrorCallbackObject ) => void; /** * Interface for Xrm.Page.data promises. From 2681fb04c1bfe98a1b630d1dda2fef99897f9786 Mon Sep 17 00:00:00 2001 From: Derek Finlinson Date: Tue, 15 Nov 2016 20:12:37 -0700 Subject: [PATCH 04/17] Correct SuccessCallbackDelegate parameter --- xrm/xrm.d.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xrm/xrm.d.ts b/xrm/xrm.d.ts index b78174523a..393594da19 100644 --- a/xrm/xrm.d.ts +++ b/xrm/xrm.d.ts @@ -489,13 +489,18 @@ declare namespace Xrm errorCode: number; message: string; } + + export interface SuccessCallbackObject + { + savedEntityReference: Page.LookupValue; + } /** * Called when the operation is successful. * Currently, only the Xrm.Utility.openQuickCreate successCallback * is passed a parameter so an optional parameter for it is included */ - export type SuccessCallbackDelegate = ( savedEntityReference?: Page.LookupValue ) => void; + export type SuccessCallbackDelegate = (object?: SuccessCallbackObject ) => void; /** * Called when the operation fails. From 67ba8bbf82b139fcbf4f78971f7e75c39bf64e1e Mon Sep 17 00:00:00 2001 From: "Derek C. Finlinson" Date: Tue, 15 Nov 2016 20:16:36 -0700 Subject: [PATCH 05/17] Update openQuickCreate success test --- xrm/xrm-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrm/xrm-tests.ts b/xrm/xrm-tests.ts index 64fb9e8c22..68ed23abb1 100644 --- a/xrm/xrm-tests.ts +++ b/xrm/xrm-tests.ts @@ -72,7 +72,7 @@ if (Xrm.Page.data.process != null) /// Demonstrate v7.1 Quick Create form -Xrm.Utility.openQuickCreate("account").then(( newRecord: Xrm.Page.LookupValue ) => { alert( `Newly created record Id: ${newRecord.id}` ); }, (error) => {console.log(`Code: ${error.errorCode}, Message: ${error.message}`)}); +Xrm.Utility.openQuickCreate("account").then(( object ) => { alert( `Newly created record Id: ${object.savedEntityReference.id}` ); }, (error) => {console.log(`Code: ${error.errorCode}, Message: ${error.message}`)}); /// Make all controls visible. From 7f912d1af6ebacd5332c98473c139d236150cd59 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Wed, 16 Nov 2016 09:11:54 +0100 Subject: [PATCH 06/17] feat(fuse-js): update types as per version 2.5.0 --- fuse/fuse.d.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fuse/fuse.d.ts b/fuse/fuse.d.ts index 9f1de6ff03..5376144e22 100644 --- a/fuse/fuse.d.ts +++ b/fuse/fuse.d.ts @@ -1,4 +1,4 @@ -// Type definitions for Fuse.js 2.2.0 +// Type definitions for Fuse.js 2.5.0 // Project: https://github.com/krisk/Fuse // Definitions by: Greg Smith // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -9,7 +9,8 @@ declare class Fuse { } declare namespace fuse { - interface IFuseOptions extends ISearchOptions { + interface IFuseOptions { + id?: string; caseSensitive?: boolean; include?: string[]; shouldSort?: boolean; @@ -18,9 +19,9 @@ declare namespace fuse { getFn?: (obj: any, path: string) => any; keys?: string[] | { name:string; weight:number} []; verbose?:boolean; - } - - interface ISearchOptions { + tokenize?: boolean; + tokenSeparator? : RegExp; + matchAllTokens?: boolean; location?: number; distance?: number; threshold?: number; From 7afa33f2d9e1893839d015ca5a8cdd914ac041f6 Mon Sep 17 00:00:00 2001 From: Marvin Bredal Lillehaug Date: Wed, 16 Nov 2016 09:45:40 +0100 Subject: [PATCH 07/17] Added rowSelection property --- react-data-grid/react-data-grid.d.ts | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/react-data-grid/react-data-grid.d.ts b/react-data-grid/react-data-grid.d.ts index 0748270a57..20d5b72b6a 100644 --- a/react-data-grid/react-data-grid.d.ts +++ b/react-data-grid/react-data-grid.d.ts @@ -8,7 +8,10 @@ declare namespace AdazzleReactDataGrid { import React = __React; - + interface __SelectionParams { + rowIdx: number, + row: any + } interface GridProps { /** * Gets the data to render in each row. Required. @@ -173,6 +176,20 @@ declare namespace AdazzleReactDataGrid { * @default 0 */ rowScrollTimeout?: number + /** + * Options object for selecting rows + */ + rowSelection?: { + showCheckbox?: boolean + enableShiftSelect?: boolean + onRowsSelected?: (rows: Array<__SelectionParams>) => void, + onRowsDeselected?: (rows: Array<__SelectionParams>) => void, + selectBy?: { + indexes?: Array + keys: { rowKey: string, values: Array } + isSelectedKey: string + } + } } /** From 896d675b6d9dae75656e499a80ae733d904350bb Mon Sep 17 00:00:00 2001 From: Marvin Bredal Lillehaug Date: Wed, 16 Nov 2016 11:00:48 +0100 Subject: [PATCH 08/17] Updated tests for react-data-grid --- react-data-grid/react-data-grid-tests.tsx | 21 +++++++++++++++++++++ react-data-grid/react-data-grid.d.ts | 15 +++++++++------ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/react-data-grid/react-data-grid-tests.tsx b/react-data-grid/react-data-grid-tests.tsx index 1b95fa8cc7..1895e1781e 100644 --- a/react-data-grid/react-data-grid-tests.tsx +++ b/react-data-grid/react-data-grid-tests.tsx @@ -247,7 +247,19 @@ class Example extends React.Component { return this.state.rows.length; } + onRowsSelected(rows: Array) { + var selectedIndexes = this.state.selectedIndexes as Array; + + this.setState({selectedIndexes: selectedIndexes.concat(rows.map(r => r.rowIdx))}); + } + onRowsDeselected(rows: Array) { + var rowIndexes = rows.map(r => r.rowIdx); + var selectedIndexes = this.state.selectedIndexes as Array; + this.setState({selectedIndexes: selectedIndexes.filter(i => rowIndexes.indexOf(i) === -1 )}); + } + render() { + let selectedRows = ['id1', 'id2']; return ( { rowHeight={50} minHeight={600} rowScrollTimeout={200} + rowSelection={{ + showCheckbox: true, + enableShiftSelect: true, + onRowsSelected: this.onRowsSelected, + onRowsDeselected: this.onRowsDeselected, + selectBy: { + keys: {rowKey: 'id', values: selectedRows} + } + }} /> ); diff --git a/react-data-grid/react-data-grid.d.ts b/react-data-grid/react-data-grid.d.ts index 20d5b72b6a..0c512c9c70 100644 --- a/react-data-grid/react-data-grid.d.ts +++ b/react-data-grid/react-data-grid.d.ts @@ -8,10 +8,12 @@ declare namespace AdazzleReactDataGrid { import React = __React; - interface __SelectionParams { + + interface SelectionParams { rowIdx: number, row: any } + interface GridProps { /** * Gets the data to render in each row. Required. @@ -182,12 +184,12 @@ declare namespace AdazzleReactDataGrid { rowSelection?: { showCheckbox?: boolean enableShiftSelect?: boolean - onRowsSelected?: (rows: Array<__SelectionParams>) => void, - onRowsDeselected?: (rows: Array<__SelectionParams>) => void, + onRowsSelected?: (rows: Array) => void, + onRowsDeselected?: (rows: Array) => void, selectBy?: { - indexes?: Array - keys: { rowKey: string, values: Array } - isSelectedKey: string + indexes?: Array; + keys?: { rowKey: string, values: Array }; + isSelectedKey?: string; } } } @@ -413,6 +415,7 @@ declare namespace AdazzleReactDataGrid { // Various events export import RowUpdateEvent = AdazzleReactDataGrid.RowUpdateEvent; + export import SelectionParams = AdazzleReactDataGrid.SelectionParams; export import CellDragEvent = AdazzleReactDataGrid.CellDragEvent; export import DragHandleDoubleClickEvent = AdazzleReactDataGrid.DragHandleDoubleClickEvent; export import CellCopyPasteEvent = AdazzleReactDataGrid.CellCopyPasteEvent; From 085fc5f4c3b68cf9257bfd3eda576a378fd1482c Mon Sep 17 00:00:00 2001 From: kwiateusz Date: Wed, 16 Nov 2016 20:53:40 +0100 Subject: [PATCH 09/17] Updated eventemmiter2 config options --- eventemitter2/eventemitter2.d.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/eventemitter2/eventemitter2.d.ts b/eventemitter2/eventemitter2.d.ts index de1be0d064..d0b0b545b1 100644 --- a/eventemitter2/eventemitter2.d.ts +++ b/eventemitter2/eventemitter2.d.ts @@ -1,4 +1,4 @@ -// Type definitions for EventEmitter2 v0.14.4 +// Type definitions for EventEmitter2 v2.2.0 // Project: https://github.com/asyncly/EventEmitter2 // Definitions by: ryiwamoto // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -23,6 +23,10 @@ interface EventEmitter2Configuration { * max listeners that can be assigned to an event, default 10. */ maxListeners?: number; + /** + * show event name in memory leak message when more than maximum amount of listeners is assigned, default false + */ + verboseMemoryLeak?: boolean; } declare class EventEmitter2 { From 681b829f01ee54c1dcde9a3f23bef6032a92540d Mon Sep 17 00:00:00 2001 From: kwiateusz Date: Wed, 16 Nov 2016 20:55:40 +0100 Subject: [PATCH 10/17] Updated eventemmiter2 tests --- eventemitter2/eventemitter2-tests.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eventemitter2/eventemitter2-tests.ts b/eventemitter2/eventemitter2-tests.ts index 747f2e87b6..840944675c 100644 --- a/eventemitter2/eventemitter2-tests.ts +++ b/eventemitter2/eventemitter2-tests.ts @@ -20,7 +20,8 @@ function testConfiguration() { wildcard: true, delimiter: '::', newListener: false, - maxListeners: 20 + maxListeners: 20, + verboseMemoryLeak: true }); var bar = new EventEmitter2({}); var bazz = new EventEmitter2(); From 4499a752a51c9b97334e5b83cfd7fbfdfa3b2dab Mon Sep 17 00:00:00 2001 From: Shi Yan Date: Thu, 17 Nov 2016 15:08:46 +0800 Subject: [PATCH 11/17] Fixed LocationDescriptor and pathOrLoc types. --- react-router/react-router.d.ts | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/react-router/react-router.d.ts b/react-router/react-router.d.ts index 321adf9bb7..80a071f18d 100644 --- a/react-router/react-router.d.ts +++ b/react-router/react-router.d.ts @@ -28,8 +28,15 @@ declare namespace ReactRouter { type ParseQueryString = (queryString: H.QueryString) => H.Query + type LocationDescriptor = { + pathname?: H.Pathname + query?: H.Query + hash?: H.Hash + state?: H.LocationState + } + interface RedirectFunction { - (location: H.LocationDescriptor): void; + (location: LocationDescriptor): void; /** * @deprecated `replaceState(state, pathname, query) is deprecated; Use `replace(location)` with a location descriptor instead. http://tiny.cc/router-isActivedeprecated */ @@ -116,9 +123,7 @@ declare namespace ReactRouter { activeStyle?: React.CSSProperties activeClassName?: string onlyActiveOnIndex?: boolean - to: RoutePattern | H.LocationDescriptor - query?: H.Query - state?: H.LocationState + to: RoutePattern | LocationDescriptor | ((...args: any[]) => LocationDescriptor) } interface Link extends React.ComponentClass {} interface LinkElement extends React.ReactElement {} @@ -216,7 +221,7 @@ declare namespace ReactRouter { interface RouterOnContext extends H.History { setRouteLeaveHook(route: PlainRoute, hook?: RouteHook): () => void; - isActive(pathOrLoc: H.LocationDescriptor, indexOnly?: boolean): boolean; + isActive(pathOrLoc: H.Path | LocationDescriptor, indexOnly?: boolean): boolean; } /* mixins */ @@ -244,15 +249,15 @@ declare namespace ReactRouter { // https://github.com/reactjs/react-router/blob/v2.4.0/upgrade-guides/v2.4.0.md interface InjectedRouter { - push: (pathOrLoc: H.LocationDescriptor) => void - replace: (pathOrLoc: H.LocationDescriptor) => void + push: (pathOrLoc: H.Path | LocationDescriptor) => void + replace: (pathOrLoc: H.Path | LocationDescriptor) => void go: (n: number) => void goBack: () => void goForward: () => void setRouteLeaveHook(route: PlainRoute, callback: RouteHook): void createPath(path: H.Path, query?: H.Query): H.Path createHref(path: H.Path, query?: H.Query): H.Href - isActive: (pathOrLoc: H.LocationDescriptor, indexOnly?: boolean) => boolean + isActive: (pathOrLoc: H.Path | LocationDescriptor, indexOnly?: boolean) => boolean } function withRouter | React.StatelessComponent | React.PureComponent>(component: C): C @@ -520,7 +525,8 @@ declare module "react-router" { export type LeaveHook = ReactRouter.LeaveHook export type ParseQueryString = ReactRouter.ParseQueryString export type RedirectFunction = ReactRouter.RedirectFunction - export type RouteComponentProps = ReactRouter.RouteComponentProps; + export type RouteComponentProps = ReactRouter.RouteComponentProps + export type RouteConfig = ReactRouter.RouteConfig export type RouteHook = ReactRouter.RouteHook export type StringifyQuery = ReactRouter.StringifyQuery export type RouterListener = ReactRouter.RouterListener From d4b2e37e1c71085aeb69401a8ccd45c1a4c36b74 Mon Sep 17 00:00:00 2001 From: Shi Yan Date: Thu, 17 Nov 2016 21:43:53 +0800 Subject: [PATCH 12/17] Export LocationDescriptor --- react-router/react-router.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/react-router/react-router.d.ts b/react-router/react-router.d.ts index 80a071f18d..930273bf7f 100644 --- a/react-router/react-router.d.ts +++ b/react-router/react-router.d.ts @@ -524,6 +524,7 @@ declare module "react-router" { export type EnterHook = ReactRouter.EnterHook export type LeaveHook = ReactRouter.LeaveHook export type ParseQueryString = ReactRouter.ParseQueryString + export type LocationDescriptor = ReactRouter.LocationDescriptor export type RedirectFunction = ReactRouter.RedirectFunction export type RouteComponentProps = ReactRouter.RouteComponentProps export type RouteConfig = ReactRouter.RouteConfig From 2f6bdf21997cc543f268def8a5df281dc27838c6 Mon Sep 17 00:00:00 2001 From: Roger Martin Date: Thu, 17 Nov 2016 08:29:40 -0700 Subject: [PATCH 13/17] Changed cascade to a string. Changed $.jstree.defaults.checkbox.cascade to a string. --- jstree/jstree.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jstree/jstree.d.ts b/jstree/jstree.d.ts index 2292da7f9c..382eae05eb 100644 --- a/jstree/jstree.d.ts +++ b/jstree/jstree.d.ts @@ -429,7 +429,7 @@ interface JSTreeStaticDefaultsCheckbox { * @name $.jstree.defaults.checkbox.cascade * @plugin checkbox */ - cascade: boolean; + cascade: string; /** * This setting controls if checkbox are bound to the general tree selection From 77462408070c6d11f0eff721f34a606e035d7e9f Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Thu, 17 Nov 2016 08:42:43 -0800 Subject: [PATCH 14/17] Fix typos --- PULL_REQUEST_TEMPLATE.md | 2 +- README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index a864dbcb13..95d0041063 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -13,5 +13,5 @@ If adding a new definition: - [ ] Include the required [files](https://github.com/DefinitelyTyped/DefinitelyTyped#create-a-new-package) and header. Base these on the README, *not* on an existing project. If changing an existing definition: -- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <> +- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <> - [ ] Increase the version number in the header if appropriate. diff --git a/README.md b/README.md index ab2080714b..a4cf7ae874 100644 --- a/README.md +++ b/README.md @@ -130,7 +130,7 @@ For a good example package, see [base64-js](https://github.com/DefinitelyTyped/D * `interface X {}`: An empty interface is essentially the `{}` type: it places no constraints on an object. * `interface IFoo {}`: Don't add `I` to the front of an interface name. * `interface Foo { new(): Foo; }`: - This defines a type of objects that are new-able. You probably want `declare class Foo { constructor(); } + This defines a type of objects that are new-able. You probably want `declare class Foo { constructor(); }`. * `const Class: { new(): IClass; }`: Prefer to use a class declaration `class Class { constructor(); }` instead of a new-able constant. * `namespace foo {}`: From ffbdae8cae2e3e131356654f322953668666a7a7 Mon Sep 17 00:00:00 2001 From: Ryan Pineo Date: Thu, 17 Nov 2016 12:57:21 -0500 Subject: [PATCH 15/17] add toastr.remove type def --- toastr/toastr-tests.ts | 3 ++- toastr/toastr.d.ts | 12 +++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/toastr/toastr-tests.ts b/toastr/toastr-tests.ts index adacb19340..c09d484dca 100644 --- a/toastr/toastr-tests.ts +++ b/toastr/toastr-tests.ts @@ -8,6 +8,7 @@ function test_basic() { t.push(toastr.error('I do not think that word means what you think it means.', 'Inconceivable!')); toastr.clear(t[0]); // clear 1 toastr.clear(); // clear all + toastr.remove(); var msg = 'Do you think Rodents of Unusual Size really exist?'; var title = 'Fireswamp Legends'; @@ -82,4 +83,4 @@ function test_fromdemo() { $('#cleartoasts').click(function () { toastr.clear(); }); -} \ No newline at end of file +} diff --git a/toastr/toastr.d.ts b/toastr/toastr.d.ts index 33a739f52e..29c507335d 100644 --- a/toastr/toastr.d.ts +++ b/toastr/toastr.d.ts @@ -174,19 +174,25 @@ interface Toastr { (): void; /** * Clear specific toast - * + * * @param toast Toast to clear */ (toast: JQuery): void; /** * Clear specific toast - * + * * @param toast Toast to clear * @param clearOptions force clearing a toast, ignoring focus */ (toast: JQuery, clearOptions: { force: boolean }): void; }; /** + * Removes all toasts (without animation) + */ + remove: { + (): void; + }; + /** * Create an error toast */ error: ToastrDisplayMethod; @@ -207,7 +213,7 @@ interface Toastr { */ warning: ToastrDisplayMethod; /** - * Get toastr version + * Get toastr version */ version: string; } From fb051545ca2ddc2f2ad0ece436a7841c10ff8e93 Mon Sep 17 00:00:00 2001 From: Andy Hanson Date: Fri, 18 Nov 2016 07:54:44 -0800 Subject: [PATCH 16/17] Add 'tslint.json' to required files --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index ab2080714b..8821765f0d 100644 --- a/README.md +++ b/README.md @@ -113,6 +113,7 @@ Your package should have this structure: | index.d.ts | This contains the typings for the package. | | foo-tests.ts | This contains sample code which tests the typings. This code does *not* run, but it is type-checked. | | tsconfig.json | This allows you to run `tsc` within the package. | +| tslint.json | Enables linting. | Generate these by running `npm run new-package -- new-package-name`. From 53038c8080e7bb3636852e9aee874db2b236d16b Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders Date: Wed, 23 Nov 2016 15:53:32 -0800 Subject: [PATCH 17/17] Make xrm tests pass strictNullChecks again The recent change to SuccessCallbackDelegate was made with strictNullChecks off in master. --- xrm/xrm-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrm/xrm-tests.ts b/xrm/xrm-tests.ts index a1e7b69cb7..65ae6e0184 100644 --- a/xrm/xrm-tests.ts +++ b/xrm/xrm-tests.ts @@ -72,7 +72,7 @@ if (Xrm.Page.data.process != null) /// Demonstrate v7.1 Quick Create form -Xrm.Utility.openQuickCreate("account").then(( object ) => { alert( `Newly created record Id: ${object.savedEntityReference.id}` ); }, (error) => {console.log(`Code: ${error.errorCode}, Message: ${error.message}`)}); +Xrm.Utility.openQuickCreate("account").then(( object ) => { if (object) alert( `Newly created record Id: ${object.savedEntityReference.id}` ); }, (error) => {console.log(`Code: ${error.errorCode}, Message: ${error.message}`)}); /// Make all controls visible.