From d9c277aabef73facd86e499a46e6da5727c9f006 Mon Sep 17 00:00:00 2001
From: Olivier Sechet <osechet@gmail.com>
Date: Thu, 8 Mar 2018 20:32:43 +0100
Subject: [PATCH] Fix no-internal-module lint

---
 types/openlayers/index.d.ts  | 92 ++++++++++++++++++------------------
 types/openlayers/tslint.json |  1 -
 2 files changed, 46 insertions(+), 47 deletions(-)

diff --git a/types/openlayers/index.d.ts b/types/openlayers/index.d.ts
index 9a6dd11642..1c2e0d12c1 100644
--- a/types/openlayers/index.d.ts
+++ b/types/openlayers/index.d.ts
@@ -13,7 +13,7 @@
 
 declare type GlobalObject = Object;
 
-declare module ol {
+declare namespace ol {
     /**
      * Error object thrown when an assertion failed. This is an ECMA-262 Error,
      * extended with a `code` property.
@@ -221,7 +221,7 @@ declare module ol {
         setAt(index: number, elem: T): void;
     }
 
-    module Collection {
+    namespace Collection {
         type EventType = string;
 
         /**
@@ -258,7 +258,7 @@ declare module ol {
      * Canvas renderer.
      *
      */
-    module color {
+    namespace color {
         /**
          * Return the color as an array. This function maintains a cache of calculated
          * arrays which means the result should not be modified.
@@ -281,7 +281,7 @@ declare module ol {
      * An {@link ol.ColorLike} can be a color, gradient or pattern accepted by
      * [CanvasRenderingContext2D.fillStyle](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/fillStyle).
      */
-    module colorlike {
+    namespace colorlike {
         /**
          * @param color Color.
          * @return The color as an ol.ColorLike
@@ -290,7 +290,7 @@ declare module ol {
         function asColorLike(color: (ol.Color | ol.ColorLike)): ol.ColorLike;
     }
 
-    module control {
+    namespace control {
         /**
          * @classdesc
          * Control to show all the attributions associated with the layer sources
@@ -697,7 +697,7 @@ declare module ol {
             setUnits(units: ol.control.ScaleLine.Units): void;
         }
 
-        module ScaleLine {
+        namespace ScaleLine {
             /**
              * @api
              */
@@ -786,7 +786,7 @@ declare module ol {
         }
     }
 
-    module coordinate {
+    namespace coordinate {
         /**
          * Add `delta` to `coordinate`. `coordinate` is modified in place and returned
          * by the function.
@@ -1100,7 +1100,7 @@ declare module ol {
     /**
      * Easing functions for {@link ol.animation}.
      */
-    module easing {
+    namespace easing {
         /**
          * Start slow and speed up.
          * @param t Input between 0 and 1.
@@ -1157,8 +1157,8 @@ declare module ol {
      * properties; see the specific event class page for details.
      *
      */
-    module events {
-        module condition {
+    namespace events {
+        namespace condition {
             /**
              * Return `true` if only the alt-key is pressed, `false` otherwise (e.g. when
              * additionally the shift-key is pressed).
@@ -1385,7 +1385,7 @@ declare module ol {
         }
     }
 
-    module extent {
+    namespace extent {
         /**
          * Build an extent that includes all given coordinates.
          *
@@ -1754,7 +1754,7 @@ declare module ol {
     /**
      * Loading mechanisms for vector data.
      */
-    module featureloader {
+    namespace featureloader {
         /**
          * Create an XHR feature loader for a `url` and `format`. The feature loader
          * loads features (with XHR), parses the features, and adds them to the
@@ -1778,7 +1778,7 @@ declare module ol {
         function xhr(url: (string | ol.FeatureUrlFunction), format: ol.format.Feature): ol.FeatureLoader;
     }
 
-    module format {
+    namespace format {
         /**
          * @classdesc
          * Feature format for reading and writing data in the EsriJSON format.
@@ -2486,7 +2486,7 @@ declare module ol {
             setLayers(layers: string[]): void;
         }
 
-        module filter {
+        namespace filter {
             /**
              * Create a `<Intersects>` operator to test whether a geometry-valued property
              * intersects a given geometry.
@@ -3802,7 +3802,7 @@ declare module ol {
         setTrackingOptions(options: PositionOptions): void;
     }
 
-    module geom {
+    namespace geom {
         /**
          * @classdesc
          * Circle geometry.
@@ -4805,7 +4805,7 @@ declare module ol {
         setMap(map: ol.Map): void;
     }
 
-    module has {
+    namespace has {
         /**
          * The ratio between physical pixels and device-independent pixels
          * (dips) on the device (`window.devicePixelRatio`).
@@ -4958,7 +4958,7 @@ declare module ol {
      */
     function inherits(childCtor: (() => any), parentCtor: (() => any)): void;
 
-    module interaction {
+    namespace interaction {
         /**
          * @classdesc
          * Allows the user to zoom by double-clicking on the map.
@@ -5015,7 +5015,7 @@ declare module ol {
             static handleEvent: any;
         }
 
-        module DragAndDrop {
+        namespace DragAndDrop {
             /**
              * @classdesc
              * Events emitted by {@link ol.interaction.DragAndDrop} instances are instances
@@ -5102,7 +5102,7 @@ declare module ol {
             getGeometry(): ol.geom.Polygon;
         }
 
-        module DragBox {
+        namespace DragBox {
             /**
              * @classdesc
              * Events emitted by {@link ol.interaction.DragBox} instances are instances of
@@ -5243,7 +5243,7 @@ declare module ol {
             constructor(opt_options?: olx.interaction.DragZoomOptions);
         }
 
-        module Draw {
+        namespace Draw {
             /**
              * @classdesc
              * Events emitted by {@link ol.interaction.Draw} instances are instances of
@@ -5510,7 +5510,7 @@ declare module ol {
             static handleEvent(mapBrowserEvent: ol.MapBrowserEvent): boolean;
         }
 
-        module Modify {
+        namespace Modify {
             /**
              * @classdesc
              * Events emitted by {@link ol.interaction.Modify} instances are instances of
@@ -5690,7 +5690,7 @@ declare module ol {
             static handleEvent(mapBrowserEvent: ol.MapBrowserEvent): boolean;
         }
 
-        module Select {
+        namespace Select {
             /**
              * @classdesc
              * Events emitted by {@link ol.interaction.Select} instances are instances of
@@ -5869,7 +5869,7 @@ declare module ol {
             removeFeature(feature: ol.Feature, opt_unlisten?: boolean): void;
         }
 
-        module Translate {
+        namespace Translate {
             /**
              * @classdesc
              * Events emitted by {@link ol.interaction.Translate} instances are instances of
@@ -5955,7 +5955,7 @@ declare module ol {
         constructor(decay: number, minVelocity: number, delay: number);
     }
 
-    module layer {
+    namespace layer {
         /**
          * @classdesc
          * Abstract base class; normally only used for creating subclasses and not
@@ -6492,7 +6492,7 @@ declare module ol {
     /**
      * Strategies for loading vector data.
      */
-    module loadingstrategy {
+    namespace loadingstrategy {
         /**
          * Strategy function for loading all features with a single request.
          * @param extent Extent.
@@ -7462,7 +7462,7 @@ declare module ol {
         setPositioning(positioning: ol.OverlayPositioning): void;
     }
 
-    module pointer {
+    namespace pointer {
         /**
          * @classdesc
          * A class for pointer events.
@@ -7532,7 +7532,7 @@ declare module ol {
      * this.
      *
      */
-    module proj {
+    namespace proj {
         /**
          * Projection units: `'degrees'`, `'ft'`, `'m'`, `'pixels'`, `'tile-pixels'` or
          * `'us-ft'`.
@@ -7856,8 +7856,8 @@ declare module ol {
         ): number;
     }
 
-    module render {
-        module canvas {
+    namespace render {
+        namespace canvas {
             /**
              * @classdesc
              * A concrete subclass of {@link ol.render.VectorContext} that implements
@@ -8091,7 +8091,7 @@ declare module ol {
      */
     type RasterOperationType = "pixel" | "image";
 
-    module source {
+    namespace source {
         /**
          * @classdesc
          * Layer source for Bing Maps tile data.
@@ -9354,7 +9354,7 @@ declare module ol {
             constructor(options: olx.source.VectorTileOptions);
         }
 
-        module wms {
+        namespace wms {
             /**
              * Available server types: `'carmentaserver'`, `'geoserver'`, `'mapserver'`,
              *     `'qgis'`. These are servers that have vendor parameters beyond the WMS
@@ -9716,7 +9716,7 @@ declare module ol {
      * ```
      *
      */
-    module style {
+    namespace style {
         /**
          * Manages the creation of image atlases.
          *
@@ -10537,11 +10537,11 @@ declare module ol {
         load(): void;
     }
 
-    module Tile {
+    namespace Tile {
         type State = number;
     }
 
-    module tilegrid {
+    namespace tilegrid {
         /**
          * Creates a tile grid with a standard XYZ tiling scheme.
          * @param opt_options Tile grid options.
@@ -11411,8 +11411,8 @@ declare module ol {
     }
 }
 
-declare module olx {
-    module animation {
+declare namespace olx {
+    namespace animation {
         interface BounceOptions {
             resolution: number;
             start?: number;
@@ -11462,7 +11462,7 @@ declare module olx {
         type AnimateCallback = (completed: boolean) => void;
     }
 
-    module control {
+    namespace control {
         interface AttributionOptions {
             className?: string;
             target?: Element;
@@ -11567,7 +11567,7 @@ declare module olx {
         }
     }
 
-    module format {
+    namespace format {
         interface ReadOptions {
             dataProjection: ol.ProjectionLike;
             featureProjection: ol.ProjectionLike;
@@ -11678,7 +11678,7 @@ declare module olx {
         }
     }
 
-    module interaction {
+    namespace interaction {
         /**
          * Object literal with config options for interactions.
          */
@@ -11841,7 +11841,7 @@ declare module olx {
         }
     }
 
-    module layer {
+    namespace layer {
         interface BaseOptions {
             opacity?: number;
             visible?: boolean;
@@ -11958,15 +11958,15 @@ declare module olx {
         }
     }
 
-    module parser {
+    namespace parser {
     }
-    module render {
+    namespace render {
         interface ToContextOptions {
             size?: ol.Size;
             pixelRatio?: number;
         }
     }
-    module source {
+    namespace source {
         interface BingMapsOptions {
             cacheSize?: number;
             culture?: string;
@@ -12283,7 +12283,7 @@ declare module olx {
             size: ol.Size;
         }
     }
-    module style {
+    namespace style {
         interface CircleOptions {
             fill?: ol.style.Fill;
             radius: number;
@@ -12383,7 +12383,7 @@ declare module olx {
             space?: number;
         }
     }
-    module tilegrid {
+    namespace tilegrid {
         interface TileGridOptions {
             extent?: ol.Extent;
             minZoom?: number;
@@ -12498,7 +12498,7 @@ declare module olx {
         getPointResolution?: ((resolution: number, coords: ol.Coordinate) => number);
     }
 
-    module view {
+    namespace view {
         interface FitOptions {
             size?: ol.Size;
             padding?: number[];
diff --git a/types/openlayers/tslint.json b/types/openlayers/tslint.json
index 1c4e20ccb2..85e089b995 100644
--- a/types/openlayers/tslint.json
+++ b/types/openlayers/tslint.json
@@ -5,7 +5,6 @@
         "ban-types": false,
         // Not sure how to work around this, or if it's necessary to
         "no-declare-current-package": false,
-        "no-internal-module": false,
         "no-single-declare-module": false,
         "no-unnecessary-class": false,
         "no-unnecessary-generics": false,