From c4cb9b4d0a8bfb7efb186c2977bd66b92f8a6f1b Mon Sep 17 00:00:00 2001 From: Roy Xue Date: Mon, 25 Sep 2017 16:56:50 -0700 Subject: [PATCH] [recharts] Improve Label props (#20016) * Fix typo and is required * Add new viewbox type * Change tp correct contributor github link --- types/recharts/index.d.ts | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/types/recharts/index.d.ts b/types/recharts/index.d.ts index aac323179f..460a1813ff 100644 --- a/types/recharts/index.d.ts +++ b/types/recharts/index.d.ts @@ -2,7 +2,7 @@ // Project: http://recharts.org/ // Definitions by: Maarten Mulders // Raphael Mueller -// Roy Xue +// Roy Xue // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -664,10 +664,18 @@ export interface TextProps extends Partial { export class Text extends React.Component { } export interface ViewBox { - x: number; - y: number; - width: number; - height: number; + x?: number; + y?: number; + width?: number; + height?: number; +} +export interface PolarViewBox { + cx?: number; + cy?: number; + innerRadius?: number; + outerRadius?: number; + startAngle?: number; + endAngle?: number; } export interface Coordinate { x: number; @@ -713,13 +721,13 @@ export interface TreemapProps { } export interface Label { - viewBox?: ViewBox; + viewBox?: ViewBox | PolarViewBox; formatter?: RechartsFunction; value: string | number; position?: PositionType; offset?: number; content?: React.ReactElement | RechartsFunction; - chilren: any; + children?: any; } export class Treemap extends React.Component { }