From 547a807d0dd936cb9eb35397ac720bd04b9f1ce1 Mon Sep 17 00:00:00 2001 From: Jackie Weng Date: Wed, 7 Nov 2018 09:47:14 +1300 Subject: [PATCH] Corrected function signature for jsPDF.addPage As per https://rawgit.com/MrRio/jsPDF/master/docs/jsPDF.html#addPage --- types/jspdf/index.d.ts | 3 ++- types/jspdf/jspdf-tests.ts | 12 ++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/types/jspdf/index.d.ts b/types/jspdf/index.d.ts index 15b9975472..51ea0eeeeb 100644 --- a/types/jspdf/index.d.ts +++ b/types/jspdf/index.d.ts @@ -2,6 +2,7 @@ // Project: https://github.com/MrRio/jsPDF // Definitions by: Amber Schühmacher // Kevin Gonnord +// Jackie Weng // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare module 'jspdf' { @@ -45,7 +46,7 @@ declare module 'jspdf' { 'getPageInfo'(pageNumberOneBased:number):any; 'getCurrentPageInfo'():any; }; - addPage(sizes?: number[]):jsPDF; + addPage(format?: string | number[], orientation?: 'p'|'portrait'|'l'|'landscape'): jsPDF; setPage(n:number):jsPDF; insertPage(beforePage:number):jsPDF; movePage(targetPage:number, beforePage:number):jsPDF; diff --git a/types/jspdf/jspdf-tests.ts b/types/jspdf/jspdf-tests.ts index 0f31005af9..ab6dd3a82a 100644 --- a/types/jspdf/jspdf-tests.ts +++ b/types/jspdf/jspdf-tests.ts @@ -13,6 +13,18 @@ function test_simple_two_page_document() { doc.save('Test.pdf'); } +function test_add_pages_with_different_format() { + var doc = new jsPDF(); + doc.text(20, 20, 'Hello world!'); + doc.addPage('a5', 'l'); + doc.text(20, 20, 'Do you like that?'); + doc.addPage('c6'); + doc.text(20, 20, 'Do you like that?'); + doc.addPage([595.28, 841.89]); + doc.text(20, 20, 'Do you like that?'); + doc.save('Test.pdf'); +} + function test_landscape() { var doc = new jsPDF('landscape'); doc.text(20, 20, 'Hello landscape world!');