From cbcae98e136bee27752224b3cfbe43e1b9254313 Mon Sep 17 00:00:00 2001 From: Kevin Lau Date: Wed, 7 Aug 2019 14:16:21 -0700 Subject: [PATCH] [node] Bugfix tty read write stream constructor (#37174) * Fix constructor for tty.ReadStream * Fix constructor for tty.WriteStream --- types/node/test/tty.ts | 4 ++-- types/node/tty.d.ts | 2 ++ types/node/v10/node-tests.ts | 4 ++-- types/node/v10/tty.d.ts | 2 ++ types/node/v11/test/tty.ts | 4 ++-- types/node/v11/tty.d.ts | 2 ++ 6 files changed, 12 insertions(+), 6 deletions(-) diff --git a/types/node/test/tty.ts b/types/node/test/tty.ts index 71eb910062..7ad96f9235 100644 --- a/types/node/test/tty.ts +++ b/types/node/test/tty.ts @@ -1,7 +1,7 @@ import * as tty from 'tty'; -const rs: tty.ReadStream = new tty.ReadStream(); -const ws: tty.WriteStream = new tty.WriteStream(); +const rs: tty.ReadStream = new tty.ReadStream(0); +const ws: tty.WriteStream = new tty.WriteStream(1); const rsIsRaw: boolean = rs.isRaw; rs.setRawMode(true); diff --git a/types/node/tty.d.ts b/types/node/tty.d.ts index aa5bd6d350..8c1b00ceaf 100644 --- a/types/node/tty.d.ts +++ b/types/node/tty.d.ts @@ -3,6 +3,7 @@ declare module "tty" { function isatty(fd: number): boolean; class ReadStream extends net.Socket { + constructor(fd: number, options?: net.SocketConstructorOpts); isRaw: boolean; setRawMode(mode: boolean): void; isTTY: boolean; @@ -14,6 +15,7 @@ declare module "tty" { */ type Direction = -1 | 0 | 1; class WriteStream extends net.Socket { + constructor(fd: number); addListener(event: string, listener: (...args: any[]) => void): this; addListener(event: "resize", listener: () => void): this; diff --git a/types/node/v10/node-tests.ts b/types/node/v10/node-tests.ts index 2745f18a72..15d578a0c1 100644 --- a/types/node/v10/node-tests.ts +++ b/types/node/v10/node-tests.ts @@ -2184,8 +2184,8 @@ async function asyncStreamPipelineFinished() { //////////////////////////////////////////////////// { - const rs: tty.ReadStream = new tty.ReadStream(); - const ws: tty.WriteStream = new tty.WriteStream(); + const rs: tty.ReadStream = new tty.ReadStream(0); + const ws: tty.WriteStream = new tty.WriteStream(1); const rsIsRaw: boolean = rs.isRaw; rs.setRawMode(true); diff --git a/types/node/v10/tty.d.ts b/types/node/v10/tty.d.ts index 7d75c89f58..f7b8281dfa 100644 --- a/types/node/v10/tty.d.ts +++ b/types/node/v10/tty.d.ts @@ -3,11 +3,13 @@ declare module "tty" { function isatty(fd: number): boolean; class ReadStream extends net.Socket { + constructor(fd: number, options?: net.SocketConstructorOpts); isRaw: boolean; setRawMode(mode: boolean): void; isTTY: boolean; } class WriteStream extends net.Socket { + constructor(fd: number); columns: number; rows: number; isTTY: boolean; diff --git a/types/node/v11/test/tty.ts b/types/node/v11/test/tty.ts index 71eb910062..7ad96f9235 100644 --- a/types/node/v11/test/tty.ts +++ b/types/node/v11/test/tty.ts @@ -1,7 +1,7 @@ import * as tty from 'tty'; -const rs: tty.ReadStream = new tty.ReadStream(); -const ws: tty.WriteStream = new tty.WriteStream(); +const rs: tty.ReadStream = new tty.ReadStream(0); +const ws: tty.WriteStream = new tty.WriteStream(1); const rsIsRaw: boolean = rs.isRaw; rs.setRawMode(true); diff --git a/types/node/v11/tty.d.ts b/types/node/v11/tty.d.ts index d7fc18647b..8ae27b990e 100644 --- a/types/node/v11/tty.d.ts +++ b/types/node/v11/tty.d.ts @@ -3,6 +3,7 @@ declare module "tty" { function isatty(fd: number): boolean; class ReadStream extends net.Socket { + constructor(fd: number, options?: net.SocketConstructorOpts); isRaw: boolean; setRawMode(mode: boolean): void; isTTY: boolean; @@ -14,6 +15,7 @@ declare module "tty" { */ type Direction = -1 | 0 | 1; class WriteStream extends net.Socket { + constructor(fd: number); addListener(event: string, listener: (...args: any[]) => void): this; addListener(event: "resize", listener: () => void): this;