From 9150a610627f4eb6432dc581472cbd1c24d7b757 Mon Sep 17 00:00:00 2001 From: Adriano Ruberto Date: Thu, 28 Jun 2018 18:25:09 +0200 Subject: [PATCH 1/3] Fix ImageManipulator actions --- types/expo/expo-tests.tsx | 4 +-- types/expo/index.d.ts | 56 ++++++++++++++++++++++----------------- 2 files changed, 33 insertions(+), 27 deletions(-) diff --git a/types/expo/expo-tests.tsx b/types/expo/expo-tests.tsx index fa329ea8e3..4f51cb0050 100644 --- a/types/expo/expo-tests.tsx +++ b/types/expo/expo-tests.tsx @@ -373,9 +373,9 @@ async () => { }; async () => { - const result = await ImageManipulator.manipulate('url', { + const result = await ImageManipulator.manipulate('url', [{ rotate: 90 - }, { + }], { compress: 0.75 }); diff --git a/types/expo/index.d.ts b/types/expo/index.d.ts index dd7057b007..85ed0b9b79 100644 --- a/types/expo/index.d.ts +++ b/types/expo/index.d.ts @@ -1513,35 +1513,41 @@ export namespace Gyroscope { * ImageManipulator */ export namespace ImageManipulator { - interface ImageResult { - uri: string; - width: number; - height: number; - base64?: string; - } + type Action = Resize | Rotate | Flip | Crop; - interface SaveOptions { - base64?: boolean; - /** A value in range `0` - `1` specifying compression level of the result image. `1` means no compression and `0` the highest compression. */ - compress?: number; - format?: 'jpeg' | 'png'; - } + interface Resize { + resize: { width: number, height: number }; + } - interface CropParameters { - originX: number; - originY: number; - width: number; - height: number; - } + interface Rotate { + rotate: number; + } - interface ImageManipulationOptions { - resize?: { width?: number; height?: number }; - rotate?: number; - flip?: { vertical?: boolean; horizontal?: boolean }; - crop?: CropParameters; - } + interface Flip { + flip?: { vertical?: boolean; horizontal?: boolean }; + } - function manipulate(uri: string, actions: ImageManipulationOptions, saveOptions?: SaveOptions): Promise; + interface Crop { + originX: number; + originY: number; + width: number; + height: number; + } + + interface ImageResult { + uri: string; + width: number; + height: number; + base64?: string; + } + + interface SaveOptions { + base64?: boolean; + compress?: FloatFromZeroToOne; + format?: 'jpeg' | 'png'; + } + + function manipulate(uri: string, actions: Action[], saveOptions?: SaveOptions): Promise; } /** From 86c4fb7f292c3604206877257f5126984fbe1b75 Mon Sep 17 00:00:00 2001 From: Adriano Ruberto Date: Thu, 28 Jun 2018 18:34:06 +0200 Subject: [PATCH 2/3] Fix undeclared type --- types/expo/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/expo/index.d.ts b/types/expo/index.d.ts index 85ed0b9b79..2e4eb675e4 100644 --- a/types/expo/index.d.ts +++ b/types/expo/index.d.ts @@ -1543,7 +1543,8 @@ export namespace ImageManipulator { interface SaveOptions { base64?: boolean; - compress?: FloatFromZeroToOne; + /** A value in range `0` - `1` specifying compression level of the result image. `1` means no compression and `0` the highest compression. */ + compress?: number; format?: 'jpeg' | 'png'; } From 30313a7e269fca5ea1e93b5c080d51df85d002cc Mon Sep 17 00:00:00 2001 From: Adriano Ruberto Date: Thu, 28 Jun 2018 18:37:42 +0200 Subject: [PATCH 3/3] Use spaces instead of tabs --- types/expo/index.d.ts | 58 +++++++++++++++++++++---------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/types/expo/index.d.ts b/types/expo/index.d.ts index 2e4eb675e4..3e86549492 100644 --- a/types/expo/index.d.ts +++ b/types/expo/index.d.ts @@ -1513,42 +1513,42 @@ export namespace Gyroscope { * ImageManipulator */ export namespace ImageManipulator { - type Action = Resize | Rotate | Flip | Crop; + type Action = Resize | Rotate | Flip | Crop; - interface Resize { - resize: { width: number, height: number }; - } + interface Resize { + resize: { width: number, height: number }; + } - interface Rotate { - rotate: number; - } + interface Rotate { + rotate: number; + } - interface Flip { - flip?: { vertical?: boolean; horizontal?: boolean }; - } + interface Flip { + flip?: { vertical?: boolean; horizontal?: boolean }; + } - interface Crop { - originX: number; - originY: number; - width: number; - height: number; - } + interface Crop { + originX: number; + originY: number; + width: number; + height: number; + } - interface ImageResult { - uri: string; - width: number; - height: number; - base64?: string; - } + interface ImageResult { + uri: string; + width: number; + height: number; + base64?: string; + } - interface SaveOptions { - base64?: boolean; - /** A value in range `0` - `1` specifying compression level of the result image. `1` means no compression and `0` the highest compression. */ - compress?: number; - format?: 'jpeg' | 'png'; - } + interface SaveOptions { + base64?: boolean; + /** A value in range `0` - `1` specifying compression level of the result image. `1` means no compression and `0` the highest compression. */ + compress?: number; + format?: 'jpeg' | 'png'; + } - function manipulate(uri: string, actions: Action[], saveOptions?: SaveOptions): Promise; + function manipulate(uri: string, actions: Action[], saveOptions?: SaveOptions): Promise; } /**