From cde2fbca9b486f23736f7cc8d4e066dbd8e876d2 Mon Sep 17 00:00:00 2001 From: Theodore Brown Date: Wed, 16 Oct 2019 11:15:47 -0600 Subject: [PATCH] Lowercase js-cookie same site cookie values (#39143) * Lowercase same site cookie values This matches the documented usage at https://github.com/js-cookie/js-cookie/#samesite, and also is more consistent with other attribute values typically entered in lowercase (e.g. domain names and true/false values). * Use lowercase value in test --- types/js-cookie/index.d.ts | 2 +- types/js-cookie/js-cookie-tests.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/types/js-cookie/index.d.ts b/types/js-cookie/index.d.ts index b65323bb39..294177da18 100644 --- a/types/js-cookie/index.d.ts +++ b/types/js-cookie/index.d.ts @@ -39,7 +39,7 @@ declare namespace Cookies { * providing some protection against cross-site request forgery * attacks (CSRF) */ - sameSite?: 'Strict' | 'Lax' | 'None'; + sameSite?: 'strict' | 'lax' | 'none'; /** * An attribute which will be serialized, conformably to RFC 6265 diff --git a/types/js-cookie/js-cookie-tests.ts b/types/js-cookie/js-cookie-tests.ts index 86802ba013..7560e6490d 100644 --- a/types/js-cookie/js-cookie-tests.ts +++ b/types/js-cookie/js-cookie-tests.ts @@ -9,7 +9,7 @@ Cookies.set('name', 'value', { expires: 7, path: '', domain: '', secure: true }) Cookies.set('name', 'value', { secure: true }); Cookies.set('name', 'value', { domain: '' }); Cookies.set('name', 'value', { path: '' }); -Cookies.set('name', 'value', { sameSite: 'Strict' }); +Cookies.set('name', 'value', { sameSite: 'strict' }); Cookies.set('name', 'value', { custom: 'property' }); // $ExpectType string | undefined