From 7bd54136c298f73236db4c55a950ddbd61a340ed Mon Sep 17 00:00:00 2001 From: khoi-fish Date: Tue, 23 Oct 2018 15:00:59 -0700 Subject: [PATCH 1/4] Added type definitions for git-rev-sync --- types/git-rev-sync/git-rev-sync-tests.ts | 13 +++++++++++++ types/git-rev-sync/index.d.ts | 15 +++++++++++++++ types/git-rev-sync/tsconfig.json | 16 ++++++++++++++++ types/git-rev-sync/tslint.json | 6 ++++++ 4 files changed, 50 insertions(+) create mode 100644 types/git-rev-sync/git-rev-sync-tests.ts create mode 100644 types/git-rev-sync/index.d.ts create mode 100644 types/git-rev-sync/tsconfig.json create mode 100644 types/git-rev-sync/tslint.json diff --git a/types/git-rev-sync/git-rev-sync-tests.ts b/types/git-rev-sync/git-rev-sync-tests.ts new file mode 100644 index 0000000000..380a1069ed --- /dev/null +++ b/types/git-rev-sync/git-rev-sync-tests.ts @@ -0,0 +1,13 @@ +import * as gitRevSync from "git-rev-sync"; + +gitRevSync.branch(); +gitRevSync.count(); +gitRevSync.date(); +gitRevSync.isDirty(); +gitRevSync.isTagDirty(); +gitRevSync.long(); +gitRevSync.message(); +gitRevSync.remoteUrl(); +gitRevSync.short(); +gitRevSync.short(); +gitRevSync.tag(); diff --git a/types/git-rev-sync/index.d.ts b/types/git-rev-sync/index.d.ts new file mode 100644 index 0000000000..ae6a864de1 --- /dev/null +++ b/types/git-rev-sync/index.d.ts @@ -0,0 +1,15 @@ +// Type definitions for git-rev-sync 1.12.0 +// Project: https://github.com/tblobaum/git-rev +// Definitions by: Khoi Nguyen +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +export function short(filePath?: string, length?: number): string; +export function long(filePath?: string): string; +export function branch(branch?: string): void; +export function count(): number; +export function date(): Date; +export function isDirty(): boolean; +export function isTagDirty(): boolean; +export function message(): string; +export function remoteUrl(): string; +export function tag(makeDirty?: boolean): string; diff --git a/types/git-rev-sync/tsconfig.json b/types/git-rev-sync/tsconfig.json new file mode 100644 index 0000000000..4ab561dfec --- /dev/null +++ b/types/git-rev-sync/tsconfig.json @@ -0,0 +1,16 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": ["es6"], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "strictFunctionTypes": true, + "baseUrl": "../", + "typeRoots": ["../"], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": ["index.d.ts", "git-rev-sync-tests.ts"] +} diff --git a/types/git-rev-sync/tslint.json b/types/git-rev-sync/tslint.json new file mode 100644 index 0000000000..65c83fb1e3 --- /dev/null +++ b/types/git-rev-sync/tslint.json @@ -0,0 +1,6 @@ +{ + "extends": "dtslint/dt.json", + "rules": { + "dt-header": false + } +} From e7cbbda23f9016683ed45c2fd5cb96ae55c9cfd8 Mon Sep 17 00:00:00 2001 From: khoi-fish Date: Tue, 23 Oct 2018 17:05:52 -0700 Subject: [PATCH 2/4] Enable dt-header for git-rev-sync --- types/git-rev-sync/tslint.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/git-rev-sync/tslint.json b/types/git-rev-sync/tslint.json index 65c83fb1e3..1bec602599 100644 --- a/types/git-rev-sync/tslint.json +++ b/types/git-rev-sync/tslint.json @@ -1,6 +1,6 @@ { "extends": "dtslint/dt.json", "rules": { - "dt-header": false + "dt-header": true } } From 4984868ac095b8929d6d2c5475f57c6578e6bdff Mon Sep 17 00:00:00 2001 From: khoi-fish Date: Tue, 23 Oct 2018 17:10:59 -0700 Subject: [PATCH 3/4] Don't include patch version for git-rev-sync --- types/git-rev-sync/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/git-rev-sync/index.d.ts b/types/git-rev-sync/index.d.ts index ae6a864de1..cfb6e8b5d7 100644 --- a/types/git-rev-sync/index.d.ts +++ b/types/git-rev-sync/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for git-rev-sync 1.12.0 +// Type definitions for git-rev-sync 1.12 // Project: https://github.com/tblobaum/git-rev // Definitions by: Khoi Nguyen // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped From c442710d7a2bfce637d3d5a86f5ec07ebf703477 Mon Sep 17 00:00:00 2001 From: khoi-fish Date: Tue, 23 Oct 2018 17:16:50 -0700 Subject: [PATCH 4/4] Fixed git-rev-sync github url and removed personal website --- types/git-rev-sync/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/git-rev-sync/index.d.ts b/types/git-rev-sync/index.d.ts index cfb6e8b5d7..e982f6b9ff 100644 --- a/types/git-rev-sync/index.d.ts +++ b/types/git-rev-sync/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for git-rev-sync 1.12 -// Project: https://github.com/tblobaum/git-rev -// Definitions by: Khoi Nguyen +// Project: https://github.com/kurttheviking/git-rev-sync-js +// Definitions by: khoi-fish // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped export function short(filePath?: string, length?: number): string;